fix(think): isolate private config from session metadata#1372
Merged
Conversation
Move Think-owned config and request metadata into a dedicated think_config table instead of mutating Session's shared assistant_config storage. Add a legacy migration path plus regression coverage, and update the current-state design notes to match the implementation. Made-with: Cursor
🦋 Changeset detectedLatest commit: 8605c1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
Make legacy assistant_config bootstrapping insert-only so stale pre-migration rows cannot overwrite newer think_config values after a cold start. Add regression coverage for rerunning the migration path after configure() updates private config. Made-with: Cursor
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Await the test-only rerunLegacyMigrationForTest RPC so failures surface at the call site and the assertion runs after the migration path completes. Made-with: Cursor
Strengthen the legacy migration regression by reading the raw think_config row instead of going back through getConfig(), which can be satisfied from the in-memory cache after configure(). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assistant_configtable into a dedicatedthink_configtable.assistant_config(session_id, key, value)whensession_id = '', plus regression coverage for that startup path.wipplan so they reflect the implementation that actually shipped in this branch.Test plan
cd packages/think && npm run test -- think-session.test.tscd packages/think && npm run buildMade with Cursor