fix(codemode): harden OpenAPI sandbox ref handling#1508
Merged
Conversation
Avoid double-truncating sandbox OpenAPI results while keeping host-side truncation for custom executors. Cache internal OpenAPI ref resolution work inside the sandbox without exposing shared mutable schema objects, and cover ref edge cases introduced by resolving specs inside generated code. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 616839a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mattzcarey
reviewed
May 12, 2026
Contributor
mattzcarey
left a comment
mattzcarey
left a comment
There was a problem hiding this comment.
this looks great. needs a changeset.
mattzcarey
approved these changes
May 12, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$refresolution work inside the sandbox while returning cloned resolved schemas so repeated refs do not share mutable objects.$refedge cases.Test plan
npx vitest run src/tests/mcp.test.tsnpx nx run @cloudflare/codemode:testgit diff --checkNotes
This follows up on #1470. That PR moved OpenAPI spec resolution into the sandbox to avoid Worker Loader RPC size limits for heavily referenced specs. This PR tightens the behavior around the new sandbox boundary and documents the expected edge-case behavior in tests.
Made with Cursor