Fix duplicate initial Agent state frames#1509
Merged
Merged
Conversation
Avoid sending stale initial state twice during WebSocket connection setup by excluding the connecting socket from lazy initialization broadcasts and then sending it one explicit state frame. This prevents client-originated setState updates from being overwritten by a late initial-state message while preserving broadcasts for other protocol clients. Adds protocol regression coverage for both the connecting-client duplicate frame case and the existing-client lazy initialization broadcast edge case. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: f7c3466 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CF_AGENT_STATEframes during Agent WebSocket connection setup by temporarily excluding only the connecting socket from lazy state-initialization broadcasts.agentsand protocol regression coverage for both the duplicate-frame case and the existing-client broadcast edge case.Test plan
npm run test:workers -w agents -- src/tests/protocol-messages.test.tsnpm run test:react -w agents -- src/react-tests/useAgent.test.tsx -t "should update state property on client setState"npm run test:react -w agents -- src/react-tests/useAgent.test.tsxnpx oxfmt --check packages/agents/src/index.ts packages/agents/src/tests/protocol-messages.test.ts packages/agents/src/tests/agents/protocol-messages.tsReadLintson edited filesMade with Cursor