Improve X509StoreContext initialization API #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
force-pushed
the
improve-verify
branch
2 times, most recently
from
9411cde to
194a13b
Compare
kornelski
reviewed
Jun 2, 2025
kornelski
reviewed
Jun 2, 2025
kornelski
reviewed
Jun 2, 2025
As X509_STORE_CTX_init requires its arguments to outlive the store context, we take ownership of all of them and put them in the store context's ex data, ensuring the soundness of the operation without the mandatory call to X509_STORE_CTX_cleanup after a closure is run.
kornelski
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce
X509StoreContextRef::init_without_cleanup.Function
X509_STORE_CTX_initrequires its arguments to outlive the store context, which is whyX509StoreContextRef::inittakes a closure which is guaranteed to be followed by a call toX509_STORE_CTX_cleanup.We can avoid that by using the store context's ex data to store and own the arguments that were passed to
X509_STORE_CTX_init.