-
Notifications
You must be signed in to change notification settings - Fork 149
Make X509Store shareable between contexts #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that you introduced a panic in cert_store_mut, as it can make currently existing code panic now when combined with set_cert_store. Let's wait for boring 5.
|
Existing code won't panic, because I haven't changed the semantics of It think it's better to deprecate |
Never mind. |
|
I assumed that the PR also implemented Clone for X509Store hence my confusion, I'm ok with the changes now. |
|
This is clever btw, nice of you to find a way without having to do boring 5. |
|
It looks good, so it can also be referenced in the external Arc packaging Cert Store. |
#362