Use 64-bit integer for session sending key counter on 32-bit platforms#460
Open
JeroenRobben wants to merge 1 commit intocloudflare:masterfrom
Open
Use 64-bit integer for session sending key counter on 32-bit platforms#460JeroenRobben wants to merge 1 commit intocloudflare:masterfrom
JeroenRobben wants to merge 1 commit intocloudflare:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sending key/nonce counter must be 64 bits wide, but the current implementation uses
AtomicUsize, which is only 32 bits wide on 32-bit platforms. This will wrap-around after 2^32 packets are sent in a single secure session, hence leading to nonce reuse. This is less likely in practice, since secure sessions are expected to rotate every 120 seconds.This change switches the counter to AtomicU64. However, AtomicU64 is not available on
arm-linux-androideabi(but is on the other arm targets), so maintaining support for that target may require usingAtomicU64from theportable_atomiccrate or aMutex<u64>