Relax version constraints for vitest#18227
Closed
ocavue wants to merge 1 commit intocloudflare:productionfrom
Closed
Relax version constraints for vitest#18227ocavue wants to merge 1 commit intocloudflare:productionfrom
ocavue wants to merge 1 commit intocloudflare:productionfrom
Conversation
Contributor
|
@penalosa , thoughts on this change? |
ToriLindsay
approved these changes
Dec 9, 2024
Contributor
|
While we do currently work with the latest 2.x version of Vitest, there's no guarantee that'll hold in future (we rely on Vitest internals that aren't covered by semver). I think we should instead update the docs to mention 2.1.8 as the latest supported version. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@cloudflare/vitest-pool-workerssupports the latest v2.1.x in this PR (cloudflare/workers-sdk#6716), so it might be a good idea to relax the version constraints in the documents too.Screenshots (optional)
N/A
Documentation checklist