Browser rendering docs to include nodejs_compat (causing errors)#19860
Closed
thomasgauvin wants to merge 1 commit intoproductionfrom
Closed
Browser rendering docs to include nodejs_compat (causing errors)#19860thomasgauvin wants to merge 1 commit intoproductionfrom
thomasgauvin wants to merge 1 commit intoproductionfrom
Conversation
Contributor
|
Preview URL: https://fed7aaa4.preview.developers.cloudflare.com Files with changes (up to 15) |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodejs_compat was removed from C3 templates. as a result, docs that were built on the notion that nodejs_compat would already be included in the pre-built templates are broken and lead to nodejs errors. this leads to a bad experience, especially for developers just getting started. i just caught this specific instance, but it would be good to verify across other pages
here is a similar pr of what I did for hyperdrive https://github.com/cloudflare/cloudflare-docs/pull/19395/files
cc @irvinebroque @andyjessop @mikenomitch for awareness