Clarify wildcard route matching behavior#28132
Merged
elithrar merged 1 commit intoproductionfrom Feb 13, 2026
Merged
Conversation
Co-authored-by: elithrar <elithrar@users.noreply.github.com>
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://f7d53c5a.preview.developers.cloudflare.com Files with changes (up to 15) |
elithrar
approved these changes
Feb 6, 2026
caley-b
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes look good. Here's a summary of what was added to the "Hostnames may optionally begin with
*" section:A caution admonition explaining that
*matches zero or more of any character (not just subdomain separators), so*example.comwill match hostnames likemyexample.comthat aren't actually subdomains ofexample.com. It recommends using two separate routes (example.com/*and*.example.com/*) if you only want to match the domain and its subdomains.A comparison table with 4 example URLs showing the difference between
*example.com/*and*.example.com/*:example.com— matched by*prefix, not by*.prefixwww.example.com/path— matched by bothmyexample.com— matched by*prefix (the surprising case from the issue), not by*.prefixnot-example.com— matched by neither (because it doesn't end withexample.com)Closes #25763
github run