docs: document inline comments in _redirects files#28171
Conversation
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
This PR requires additional review attention because it affects the following areas: PartialsThis PR updates partial files, which are pieces of content used across multiple files in our Render component.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://237d7f49.preview.developers.cloudflare.com |
|
While testing this OpenCode found this bug which I've raised a PR for cloudflare/workers-sdk#12627 |
agh, I tested this locally and assumed wrongly given that it worked locally that it would be the same in prod, but deploying the worker does throw errors in the deployment linter. Sorry! I've thrown up a revert. |
It's not live. |
|
@vicb no worries, I've since got this change reverted so once you're ready then we can revert that revert. My bad for assuming that what worked locally was enabled remotely. |
Summary
Documents the new inline comment support for
_redirectsfiles, added in cloudflare/workers-sdk#12467.Changes to
src/content/partials/workers/redirects.mdx:### Commentssubsection documenting both full-line and inline comment syntax#starts a comment;#within a URL like/page#sectionis preserved)Important
Do not merge until the backend is running the new version of
workers-sharedthat includes inline comment support. The feature is implemented inworkers-shared(PR) and won't be live until the backend picks up the new package version.Documentation checklist
Link to Devin run: https://app.devin.ai/sessions/b6cb3af4527945cfadfb345c2921fe86
Requested by: @petebacondarwin