[Agents] Add note about ES2021 tsconfig target for @callable() decorator#28334
[Agents] Add note about ES2021 tsconfig target for @callable() decorator#28334elithrar merged 2 commits intoproductionfrom
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
/bonk validate this re: ES2021 tsconfig + decorators, vite, and Workers |
|
Here is my review of this PR: Technical Accuracy: The ES2021 advice is correctThe core claim -- setting
ES2021 specifically is the right recommendation -- it matches the official starter template and is more conservative than ES2022 (which would also fix the SyntaxError but leaves class fields native, creating potential decorator/field interaction edge cases). Content ReviewWhat is good
What could be improved1. The note in 2. Both notes lack a brief "why." A single clause explaining the mechanism would help users understand and not just cargo-cult the fix. For example:
3. Missing warning about
...would save users from a much harder-to-debug issue than the SyntaxError. 4. Minor style nit. The quick-start troubleshooting heading at line 280 uses the exact error text VerdictThe PR is correct and shippable as-is. The advice works and matches what the official starter template does. The improvements above (explain why, warn about |
|
/bonk address the documented improvements, and then re-review for clarity and styleguide. ensure all code is correct. |
Co-authored-by: elithrar <elithrar@users.noreply.github.com>
|
All improvements have been applied and verified. Here is a summary of the changes: Changes madecallable-methods.mdx:
quick-start.mdx:
Verification
|
No description provided.