Skip to content

add workers vpc terraform to docs#28492

Merged
thomasgauvin merged 4 commits intoproductionfrom
thomasgauvin-workers-vpc-terraform-docs
Feb 23, 2026
Merged

add workers vpc terraform to docs#28492
thomasgauvin merged 4 commits intoproductionfrom
thomasgauvin-workers-vpc-terraform-docs

Conversation

@thomasgauvin
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

This PR requires additional review attention because it affects the following areas:

Redirects

This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:

  • /workers-vpc/configuration/vpc-services/

@github-actions
Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
* @cloudflare/pcx-technical-writing
/src/content/docs/workers/ @cloudflare/workers-docs, @GregBrimble, @irvinebroque, @mikenomitch, @korinne, @WalshyDev, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing, @cloudflare/wrangler, @mattietk, @cloudflare/dev-plat-leads

@elithrar
Copy link
Copy Markdown
Collaborator

/bonk fix the build issues, review and address any findings

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Feb 21, 2026

All fixes have been committed. Here's a summary of the issues found and resolved:

Issues Fixed

Build-breaking (HIGH)

  1. Broken link /workers-vpc/reference/manage-vpc-services/ in infrastructure-as-code.mdx:266 — the target page does not exist. Fixed by updating to /workers-vpc/configuration/vpc-services/terraform/ which is the correct page for the Terraform walkthrough.

Content correctness (MEDIUM)

  1. json code blocks with // comments in vpc-services/index.mdx — JSON does not support comments. Changed to jsonc (2 blocks).
  2. Wrong pcx_content_type: concept in terraform.mdx — the page is procedural ("Configure with Terraform"), not conceptual. Changed to how-to.
  3. Missing description frontmatter in terraform.mdx — added for SEO.
  4. $today magic string in raw tf code block in terraform.mdx:95 — this only works inside <WranglerConfig> components. Replaced with an actual date and an inline comment.

Code cleanliness (LOW)

  1. Unused imports in vpc-services/index.mdxGlossaryTooltip, Tabs, TabItem, and Example were imported but never used. Removed.

Pre-existing issues noted (not in scope)

  • Line 39 of vpc-services/index.mdx uses -- instead of em dash
  • Line 35 uses "coming soon" phrasing (triggers Semgrep warning)
  • infrastructure-as-code.mdx:74 uses the contraction "don't"
  • infrastructure-as-code.mdx:33 uses "here" as link text

github run

@elithrar
Copy link
Copy Markdown
Collaborator

/bonk fix all preexisting issues and re-review.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Feb 23, 2026

All pre-existing issues have been fixed and committed. Here is a summary of the re-review:

Fixes Applied

All four pre-existing issues noted by the previous review have been resolved:

# File Issue Fix
1 vpc-services/index.mdx:32 -- instead of em dash Replaced with
2 infrastructure-as-code.mdx:74 Contraction "don't" + missing word ("could just the") Changed to "do not" and added missing "use"
3 infrastructure-as-code.mdx:33 Vague "here" link text (×2) Rewrote with descriptive link text
4 infrastructure-as-code.mdx:51 $today in raw tf code block (not inside <WranglerConfig>) Replaced with actual date + inline comment

Re-review Results

After fixing the above, I performed a full re-review of all three changed files. No additional issues found:

  • Frontmatter: All valid — pcx_content_type, title, description are correct
  • MDX syntax: No unescaped {, }, <, > in prose
  • Components: All imports match usage; WranglerConfig and Render used correctly
  • Code blocks: All have lowercase language identifiers (tf, jsonc)
  • Links: All internal links verified to exist; trailing slashes present; no vague link text
  • Heading hierarchy: Sequential (H2 → H3) throughout
  • Style: No contractions, active voice, correct terminology
  • Redirect: Not needed — renaming vpc-services.mdxvpc-services/index.mdx preserves the same URL path
  • Type check: npm run check passes with 0 errors

Remaining note (not actionable)

  • Line 28 of vpc-services/index.mdx uses "coming soon" phrasing which triggers a Semgrep warning. This describes the product roadmap and is likely intentional — the product team should update it when tcp support ships.

github run

Comment thread src/content/docs/workers/platform/infrastructure-as-code.mdx
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Feb 23, 2026

@Oxyjun Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@thomasgauvin thomasgauvin enabled auto-merge (squash) February 23, 2026 16:37
@thomasgauvin thomasgauvin merged commit 028aa77 into production Feb 23, 2026
9 checks passed
@thomasgauvin thomasgauvin deleted the thomasgauvin-workers-vpc-terraform-docs branch February 23, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants