refactor: use API token instead of legacy API key#797
refactor: use API token instead of legacy API key#797twsansbury wants to merge 13 commits intocloudflare:productionfrom twsansbury:use-api-token
Conversation
|
@bkrebsbach, the stream documentation was updated in #149 to start using API tokens. The GraphQL usage example uses an API token: However, the document explicitly states API tokens cannot be used: These seem to be in conflict with one another. If I knew which was correct, I would be glad to fix the documentation as part of this pull request. |
|
@Everlag / @renandincer - do we not support API tokens? See @twsansbury's comments:
|
|
@twsansbury The limitation requiring API keys is no longer valid, I've confirmed that API tokens work for Stream. |
tlozoot
left a comment
There was a problem hiding this comment.
Thanks, LGTM. fyi @crwaters16 as well
...s/analytics/src/content/graphql-api/getting-started/authentication/graphql-client-headers.md
Outdated
Show resolved
Hide resolved
products/analytics/src/content/graphql-api/tutorials/build-your-own-analytics/index.md
Outdated
Show resolved
Hide resolved
|
Given the number of code owners, should I split this into different merge requests? I am worried I will continuously need to rebase and resolve merge conflicts while waiting for approval from other code owners. |
| Next, you will need to add the CNAME record that is provided in the results, ie `name: _ca3-fbc2086e83a647d4822fefa68f26fc55.cname.example.com` and `cname_target:dcv.digicert.com`, at the Authoritative DNS provider for the hostname. This CNAME record information can also be located in the Custom Hostname section of the SSL dashboard. | ||
|
|
||
| The certificate should validate relatively soon after its added. If you’d like to check immediately simply send a `PATCH` with the same payload. No newline at end of file | ||
| The certificate should validate relatively soon after its added. If you’d like to check immediately simply send a `PATCH` with the same payload. |
There was a problem hiding this comment.
Should be "it is" or "it's"
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 7d3d958 | config.toml | View secret |
| - | Generic High Entropy Secret | 58b6333 | products/ddos-protection/docs-config.js | View secret |
| - | Generic High Entropy Secret | f5ad72d | products/ddos-protection/docs-config.js | View secret |
| 3543783 | Generic High Entropy Secret | 51cbbad | products/ruleset-engine/docs-config.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
This PR was opened before the developer doc site was moved to Cloudflare Pages. There are many conflicting branches. I'm going to close it now, but feel free to open a new issue or ask any questions. |
Some products provides usage examples for the legacy API keys authorization scheme. Where possible, the documentation and usage examples should direct users to use the recommended API tokens authorization scheme.