Allow routing ctx props to Server#268
Merged
Merged
Conversation
|
| await this.ctx.blockConcurrencyWhile(async () => { | ||
| this.#status = "starting"; | ||
| await this.onStart(); | ||
| await this.onStart(this.#_props); |
Collaborator
There was a problem hiding this comment.
hmm one problem is that onStart is called before an alarm on a new DO, and props won't be available there. it's... fine. they'll have to implement it in app layer anyway (at least for now)
threepointone
approved these changes
Aug 27, 2025
threepointone
added a commit
that referenced
this pull request
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we now can have props in
ExecutionContextwhen using an OAuthProvider, we could optionally route them to theServerand make them available as a parameter inonStart.The opt-in is fairly straightforward, if you want to make sure your
Servertracks props, you'd use:A class that extends
Servercan make sure thepropsare available during the entire lifecycle of the DO by using:Related to cloudflare/agents#415, as it props were only implemented in
McpServer