Version Packages#384
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
partyserver@0.5.2
Patch Changes
#383
fe030f6Thanks @threepointone! -setName()is now the sanctioned bootstrap API for non-idFromNameDOs.When
ctx.id.nameis undefined (e.g. Cloudflare Agents facets, which are spawned viactx.facets.get(...)rather thanidFromName()),setName(name)now persists the name to the legacy__ps_namestorage key in addition to stashing it in memory. This means cold-wake invocations of the DO recover the name through#ensureInitialized()'s legacy storage fallback without the framework having to reach into PartyServer's private storage layout.Frameworks that previously did:
can now do:
Backward compatible:
idFromName()/getByName()(the happy path),setName()continues to NOT write storage —ctx.id.nameis the source of truth andsetName()is just a no-op-plus-onStart.setName()would do.setName()'s@deprecateddocblock has been clarified: it remains the supported API for framework-level bootstrap of non-idFromNameDOs and for delivering initialpropstoonStart(). The deprecation only applies to redundant calls on DOs that were addressed viaidFromName().