refactor: delete app-dev-server.ts, point all callers at entries/ directly (#253 batch 3)#379
Merged
james-elicx merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
…es/ directly The file was already a pure re-export shim with no logic of its own. Update every import/dynamic-import site to point straight at the individual entry modules: entries/app-rsc-entry.ts ← generateRscEntry, AppRouterConfig entries/app-ssr-entry.ts ← generateSsrEntry entries/app-browser-entry.ts ← generateBrowserEntry Sites updated: packages/vinext/src/index.ts tests/entry-templates.test.ts tests/app-router.test.ts tests/shims.test.ts Also update stale comments in: server/middleware-codegen.ts, server/request-pipeline.ts, server/instrumentation.ts, shims/metadata.tsx, tests/rsc-streaming.test.ts, tests/nextjs-compat/rsc-context-lazy-stream.test.ts, examples/app-router-cloudflare/instrumentation*.ts
commit: |
|
Collaborator
Author
|
/bigbonk review |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review: Approve
Clean mechanical refactor. Verified the following:
Correctness
- The deleted
app-dev-server.tsre-exported exactly 4 symbols:AppRouterConfig(type),generateRscEntry,generateSsrEntry,generateBrowserEntry. All callers now import directly fromentries/app-rsc-entry.ts,entries/app-ssr-entry.ts, andentries/app-browser-entry.tsrespectively. index.tsimports updated correctly (3 separate imports replacing 1 barrel import).entry-templates.test.tsimports updated, including theAppRouterConfigtype.app-router.test.tsandshims.test.tsdynamic imports (await import(...)) all point to the correct entry modules.
Completeness
- Grepped the full repo for
app-dev-server— zero remaining references outside.git/metadata, except the intentional "Previously housed in server/app-dev-server.ts" comment inentries/app-rsc-entry.ts:8. - All 21 changed files are comment/import updates only — no behavioral changes.
Comment accuracy
- AGENTS.md key files table, test mapping table, and dev/prod parity section all updated.
- README.md directory tree updated to list the
entries/directory and removeapp-dev-server.tsfromserver/. .opencode/agent docs and command files updated consistently.TRACKING.mdreferences (10 occurrences) all point to the correct entry files.
No functional changes — pure import rewiring and comment updates. No risk to dev/prod parity.
Contributor
|
Reviewed and approved PR #379. Summary:
|
james-elicx
added a commit
that referenced
this pull request
Mar 9, 2026
…ectly (#253 batch 3) (#379) * refactor: delete app-dev-server.ts and update all references to entries/ directly The file was already a pure re-export shim with no logic of its own. Update every import/dynamic-import site to point straight at the individual entry modules: entries/app-rsc-entry.ts ← generateRscEntry, AppRouterConfig entries/app-ssr-entry.ts ← generateSsrEntry entries/app-browser-entry.ts ← generateBrowserEntry Sites updated: packages/vinext/src/index.ts tests/entry-templates.test.ts tests/app-router.test.ts tests/shims.test.ts Also update stale comments in: server/middleware-codegen.ts, server/request-pipeline.ts, server/instrumentation.ts, shims/metadata.tsx, tests/rsc-streaming.test.ts, tests/nextjs-compat/rsc-context-lazy-stream.test.ts, examples/app-router-cloudflare/instrumentation*.ts * docs: update app-dev-server.ts references in markdown files to entries/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows #377 and #378. Now that all generators live in
entries/, theserver/app-dev-server.tsshim (which was just three re-exports) can be deleted.Changes:
packages/vinext/src/server/app-dev-server.tsentries/app-rsc-entry.ts—generateRscEntry,AppRouterConfigentries/app-ssr-entry.ts—generateSsrEntryentries/app-browser-entry.ts—generateBrowserEntryapp-dev-server.tsreferences in comments across source files, tests, and examplesFiles updated:
index.ts,tests/entry-templates.test.ts,tests/app-router.test.ts,tests/shims.test.ts, plus comments in 6 other files.Verification
pnpm run lint— 0 warnings, 0 errorspnpm run typecheck— cleanpnpm test tests/entry-templates.test.ts— 10/10 pass