Implement std:error:Error trait for ImplementationError#78
Merged
AkshatM merged 1 commit intocloudflare:mainfrom Apr 17, 2026
Merged
Implement std:error:Error trait for ImplementationError#78AkshatM merged 1 commit intocloudflare:mainfrom
AkshatM merged 1 commit intocloudflare:mainfrom
Conversation
armfazh
approved these changes
Apr 17, 2026
Contributor
armfazh
left a comment
armfazh
left a comment
There was a problem hiding this comment.
one comment only about core vs std.
| WebBotAuth(WebBotAuthError), | ||
| } | ||
|
|
||
| impl std::fmt::Display for ImplementationError { |
Contributor
There was a problem hiding this comment.
consider implement from core module (here and below), in case the crate needs to comply no-std
Suggested change
| impl std::fmt::Display for ImplementationError { | |
| impl core::fmt::Display for ImplementationError { |
AkshatM
added a commit
to AkshatM/web-bot-auth
that referenced
this pull request
Apr 22, 2026
- [Implement `std:error:Error` trait for `ImplementationError`](cloudflare#78) - [refactor: replace time::Duration with std::time::Duration in public API](cloudflare#79). The last makes a breaking change to our APIs, and so mandates a minor version bump per our existing convention.
Merged
AkshatM
added a commit
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73