Gate prototypes behind compatability flag for cache: no-store #2429
Conversation
| const req = new Request('https://example.org', { cache: 'no-store' }); | ||
| assert.strictEqual(req.cache, 'no-store'); | ||
| } else { | ||
| assert.throws(() => { |
There was a problem hiding this comment.
Shouldn't we also be putting this new behaviour (throwing when cache is present) behind the compatibility flag too?
There was a problem hiding this comment.
When the compat flag is off, we need to be using the old jsg::Unimplemented definition, which would make this code irrelevant.
There was a problem hiding this comment.
we can't exactly be using that dynamically it's part of the type right? Should we just be throwing the same error?
There was a problem hiding this comment.
Sure you can make it dynamic. Rename jsg::Unimplemented getCache(); to jsg::Unimplemented getUnimplementedCache();, then do something like this in the JSG_RESOURCE_TYPE block:
if (flags.getCacheOptionEnabled()) {
JSG_READONLY_PROTOTYPE_PROPERTY(cache, getCache);
} else {
JSG_READONLY_PROTOTYPE_PROPERTY(cache, getUnimplementedCache);
}
So the exported cache property in JS hooks up to different implementations depending on the flag.
tewaro
force-pushed
the
AdityaAtulTewari/enable-prototype-compatability-for-cache-no-store
branch
from
6257929 to
cc84143
Compare
|
Can we please completely revert the previous change, and then re-land? I want to be able to see a diff from the known-good state to the final state, so I can verify that everything new has been properly gated. |
3 participants
Small bug fix, where prototype for
cachewas not gated behind the compatibility flag in #2409.