Provide mechanism for autopopulating node.js process.env by jasnell · Pull Request #3311 · cloudflare/workerd

jasnell · 2025-01-09T17:01:54Z

Autopopulates the process.env from bindings in local dev. A similar PR will be needed internally to enable it there as it won't be automatic.

See caveats: #3311 (comment)

vicb

@irvinebroque can we discuss this?

I oppose this change of it exposed secrets to the world via process.env

jasnell · 2025-01-10T17:15:48Z

I oppose this change of it exposed secrets to the world via process.ENV

To be clear... the change puts any TEXT binding on process.env. We have no way of knowing if a a TEXT binding contains something that is considered a secret or not. If tooling insists on adding secrets to the worker configuration using a TEXT binding then this would mean we just cannot populate process.env automatically at all right now because we have zero ability to differentiate if the value of the TEXT binding is secret or not.

jasnell · 2025-01-14T20:27:16Z

Moved back to draft due to continued backend discussion on how the implementation intersects with non-nodejs-compat related aspects of the runtime.

Signed-off-by: James M Snell <jsnell@cloudflare.com>

Objection is noted but decision has been made to move forward.

jasnell · 2025-02-25T20:35:14Z

Rebased the PR and expanded comments. Maintained the existing implementation approach. If it becomes necessary it ought to be able to further change the underlying implementation details without breaking changes. The hypothetical case around how to handle potential new binding types that evaluate to strings can be addressed separately later when they are no longer hypothetical. An internal PR is necessary.

irvinebroque

👍 let's find a way to ship

Current approach meets the immediate need. Hypothetical additional cases can be looked at separately later.

vicb · 2025-02-25T21:04:27Z

Could a doc PR be prepared for this change?

jasnell · 2025-02-25T21:13:43Z

There already is a doc PR cloudflare/cloudflare-docs#19187

vicb · 2025-02-26T07:37:11Z

What are the plans regarding:

Autopopulates the process.env from bindings in local dev. A similar PR will be needed internally to enable it there as it won't be automatic.

When this will be activated on EW? When can this be enabled?

Does wrangler needs to be updated to support the flag/CLI options, is there a tracking issue?

Co-authored-by: Alex Robinson <arobinson@cloudflare.com>

Refs: cloudflare/workerd#3311

jasnell requested review from anonrig, danlapid and irvinebroque January 9, 2025 17:01

jasnell requested review from a team as code owners January 9, 2025 17:01

jasnell requested a review from a team January 9, 2025 17:01

jasnell force-pushed the jasnell/workerd-autopopulate-process-env branch 3 times, most recently from 122a5b8 to d08499e Compare January 9, 2025 21:36

kentonv reviewed Jan 9, 2025

View reviewed changes

Comment thread src/workerd/server/workerd-api.c++ Outdated

anonrig reviewed Jan 10, 2025

View reviewed changes

Comment thread src/node/internal/util.d.ts Outdated

Comment thread src/workerd/api/node/util.h

jasnell force-pushed the jasnell/workerd-autopopulate-process-env branch 2 times, most recently from 00c74b2 to f6f3f64 Compare January 10, 2025 15:12

jasnell requested a review from anonrig January 10, 2025 15:15

jasnell force-pushed the jasnell/workerd-autopopulate-process-env branch from f6f3f64 to 7f531ca Compare January 10, 2025 15:15

danlapid approved these changes Jan 10, 2025

View reviewed changes

jasnell force-pushed the jasnell/workerd-autopopulate-process-env branch from 7f531ca to 5356dc7 Compare January 10, 2025 15:54

anonrig approved these changes Jan 10, 2025

View reviewed changes

jasnell commented Jan 10, 2025

View reviewed changes

Comment thread src/workerd/api/node/util.h Outdated

jasnell force-pushed the jasnell/workerd-autopopulate-process-env branch from e6519ab to 09a9009 Compare January 10, 2025 16:28

vicb previously requested changes Jan 10, 2025

View reviewed changes

vicb reviewed Jan 10, 2025

View reviewed changes

Comment thread src/workerd/io/compatibility-date.capnp Outdated

vicb reviewed Jan 10, 2025

View reviewed changes

Comment thread src/workerd/api/node/tests/process-nodejs-test.js

vicb reviewed Jan 10, 2025

View reviewed changes

Comment thread src/workerd/jsg/setup.h Outdated

jasnell commented Jan 10, 2025

View reviewed changes

Comment thread src/workerd/api/node/tests/process-nodejs-test.js

kentonv reviewed Jan 10, 2025

View reviewed changes

Comment thread src/workerd/server/workerd-api.c++

vicb reviewed Jan 11, 2025

View reviewed changes

Comment thread src/workerd/api/node/util.c++

vicb reviewed Jan 11, 2025

View reviewed changes

Comment thread src/workerd/io/compatibility-date.capnp Outdated

vicb reviewed Jan 11, 2025

View reviewed changes

Comment thread src/workerd/jsg/setup.h

jasnell enabled auto-merge (squash) January 14, 2025 16:04

anonrig approved these changes Jan 14, 2025

View reviewed changes

jasnell disabled auto-merge January 14, 2025 18:21

jasnell marked this pull request as draft January 14, 2025 18:21

jasnell added nodejs compat api labels Jan 14, 2025

vicb mentioned this pull request Jan 30, 2025

Revert "fix(wrangler): handling of process.env.NODE_ENV in bundling mode" cloudflare/workers-sdk#7967

Merged

jasnell force-pushed the jasnell/workerd-autopopulate-process-env branch 3 times, most recently from dc005bb to 590cb18 Compare February 25, 2025 20:27

Implement process.env

a36ee3c

Signed-off-by: James M Snell <jsnell@cloudflare.com>

jasnell force-pushed the jasnell/workerd-autopopulate-process-env branch from 590cb18 to a36ee3c Compare February 25, 2025 20:32

jasnell marked this pull request as ready for review February 25, 2025 20:32

irvinebroque reviewed Feb 25, 2025

View reviewed changes

anonrig approved these changes Feb 25, 2025

View reviewed changes

jasnell merged commit ebfedb9 into main Feb 25, 2025

jasnell deleted the jasnell/workerd-autopopulate-process-env branch February 25, 2025 22:17

dario-piotrowicz mentioned this pull request Mar 12, 2025

[vite-plugin] improve workerd process.env support cloudflare/workers-sdk#8457

Closed

gabivlj pushed a commit to gabivlj/workerd that referenced this pull request Jun 18, 2025

Implement process.env (cloudflare#3311)

b056e22

Co-authored-by: Alex Robinson <arobinson@cloudflare.com>

jasnell added a commit to jasnell/cloudflare-docs that referenced this pull request Jul 31, 2025

Document the process.env handling and compat flags

9220bba

Refs: cloudflare/workerd#3311

jasnell added a commit to jasnell/cloudflare-docs that referenced this pull request Aug 12, 2025

Document the process.env handling and compat flags

c2f757e

Refs: cloudflare/workerd#3311

jasnell added a commit to cloudflare/cloudflare-docs that referenced this pull request Aug 12, 2025

Document the process.env handling and compat flags (#19187)

e5285f0

Refs: cloudflare/workerd#3311

thomasgauvin pushed a commit to cloudflare/cloudflare-docs that referenced this pull request Aug 15, 2025

Document the process.env handling and compat flags (#19187)

7219899

Refs: cloudflare/workerd#3311

Conversation

jasnell commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vicb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell commented Jan 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasnell commented Jan 14, 2025

Uh oh!

jasnell commented Feb 25, 2025

Uh oh!

irvinebroque left a comment

Choose a reason for hiding this comment

Uh oh!

vicb commented Feb 25, 2025

Uh oh!

jasnell commented Feb 25, 2025

Uh oh!

vicb commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jasnell commented Jan 9, 2025 •

edited

Loading

vicb left a comment •

edited

Loading