Skip to content

use internal setImmediate/clearImmediate fns for node:timers#3382

Merged
anonrig merged 1 commit intomainfrom
yagiz/export-timers-to-use-internal-impl
Jan 21, 2025
Merged

use internal setImmediate/clearImmediate fns for node:timers#3382
anonrig merged 1 commit intomainfrom
yagiz/export-timers-to-use-internal-impl

Conversation

@anonrig
Copy link
Copy Markdown
Contributor

@anonrig anonrig commented Jan 21, 2025

Fixes #3377

@anonrig anonrig requested a review from jasnell January 21, 2025 15:42
@anonrig anonrig requested review from a team as code owners January 21, 2025 15:42
@anonrig anonrig requested review from a team, Frederik-Baetens and vicb January 21, 2025 15:42
Comment thread src/workerd/api/node/timers.c++ Outdated
Comment thread src/workerd/api/node/timers.c++
Comment thread src/node/internal/internal_timers_promises.ts Outdated
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the compat date in the test to the oldest possible compat date (#3377 (comment))

@jasnell
Copy link
Copy Markdown
Collaborator

jasnell commented Jan 21, 2025

Could you please update the compat date in the test to the oldest possible compat date (#3377 (comment))

Either this or the nodejs_compat_v2 compat flag can be explicitly disabled. The point would be that the test needs to show these methods work via node:timers without nodejs_compat_v2 enabled.

@anonrig anonrig force-pushed the yagiz/export-timers-to-use-internal-impl branch from f1f530a to 73eff6f Compare January 21, 2025 16:44
@anonrig anonrig requested review from jasnell and vicb January 21, 2025 16:45
@anonrig anonrig enabled auto-merge (squash) January 21, 2025 16:48
@vicb
Copy link
Copy Markdown
Contributor

vicb commented Jan 21, 2025

Could you please update the compat date in the test to the oldest possible compat date (#3377 (comment))

Either this or the nodejs_compat_v2 compat flag can be explicitly disabled. The point would be that the test needs to show these methods work via node:timers without nodejs_compat_v2 enabled.

But using the oldest compat date has the benefit to test all the flags and doing it everywhere (as possible) could prevent the issue we had here

@anonrig anonrig merged commit 9cea433 into main Jan 21, 2025
@anonrig anonrig deleted the yagiz/export-timers-to-use-internal-impl branch January 21, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node:timers breaks for Workers without the nodejs_compat_v2 compatibility flag

3 participants