Skip to content

Remove -latomic flag from V8 bazel build. #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikcorry merged 1 commit into from
Apr 7, 2025
Merged

Remove -latomic flag from V8 bazel build. #3891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/deps/v8.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ PATCHES = [
"0018-Disable-memory-leak-assert-when-shutting-down-V8.patch",
"0019-Enable-V8-shared-linkage.patch",
"0020-Modify-where-to-look-for-fast_float-and-simdutf.patch",
"0021-Remove-unneded-latomic-linker-flag.patch",
]

# V8 and its dependencies
Expand Down
19 changes: 19 additions & 0 deletions patches/v8/0021-Remove-unneded-latomic-linker-flag.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Erik Corry <erikcorry@chromium.org>
Date: Mon, 7 Apr 2025 12:32:30 +0200
Subject: Remove unneded -latomic linker flag


diff --git a/bazel/defs.bzl b/bazel/defs.bzl
index 497246e6e5f63b5e73251177317a3c99cbdc7b09..5f1b78775caa39c840d92daffd51125e7b4a0705 100644
--- a/bazel/defs.bzl
+++ b/bazel/defs.bzl
@@ -205,7 +205,7 @@ def _default_args():
"Shell32.lib",
],
"@v8//bazel/config:is_macos": ["-pthread"],
- "//conditions:default": ["-Wl,--no-as-needed -ldl -latomic -pthread"],
+ "//conditions:default": ["-Wl,--no-as-needed -ldl -pthread"],
}) + select({
":should_add_rdynamic": ["-rdynamic"],
"//conditions:default": [],