fix streams wpt piping/pipe-through.any.js #5745
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
reviewed
Dec 22, 2025
danlapid
approved these changes
Dec 22, 2025
|
The generated output of |
anonrig
force-pushed
the
yagiz/wpt-streams-1
branch
from
0370d0d to
bcf87b9
Compare
petebacondarwin
approved these changes
Dec 22, 2025
jasnell
reviewed
Dec 22, 2025
| jsg::Optional<jsg::Ref<AbortSignal>> signal; | ||
|
|
||
| JSG_STRUCT(preventClose, preventAbort, preventCancel, signal); | ||
| JSG_STRUCT(preventAbort, preventCancel, preventClose, signal); |
Collaborator
There was a problem hiding this comment.
Why change the position on this/?
Collaborator
|
Please do not merge this without coordinating on the timing of also landing #5670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick easy fix to increase our web-platform test coverage