Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Dec 22, 2025

Fixes several tests. I'm not sure if we should put it behind a compat flag or not.

@anonrig anonrig requested review from a team as code owners December 22, 2025 21:02
@anonrig anonrig force-pushed the yagiz/throw-appropriate-errors branch from 94b64f3 to 4aec1ad Compare December 22, 2025 21:03
@anonrig anonrig requested a review from jasnell December 22, 2025 21:06
Copy link
Collaborator

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please don't land without coordinating around the landing of #5670

@anonrig anonrig force-pushed the yagiz/throw-appropriate-errors branch from 4aec1ad to 5b09510 Compare December 23, 2025 16:32
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 23, 2025

CodSpeed Performance Report

Merging #5748 will improve performance by 12.86%

Comparing yagiz/throw-appropriate-errors (5b09510) with main (78a4eec)

Summary

⚡ 1 improvement
✅ 56 untouched
⏩ 34 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
simpleStringBody[Response] 22.4 µs 19.8 µs +12.86%

Footnotes

  1. 34 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants