Skip to content

fix streams backpressure condition check #5758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anonrig merged 1 commit into from
Dec 24, 2025
Merged

fix streams backpressure condition check #5758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/workerd/api/streams/standard.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,7 +1499,7 @@ template <typename Self>
void WritableImpl<Self>::updateBackpressure(jsg::Lock& js) {
KJ_ASSERT(isWritable());
KJ_ASSERT(!isCloseQueuedOrInFlight());
bool bp = getDesiredSize() < 0;
bool bp = getDesiredSize() <= 0;

if (bp != flags.backpressure) {
flags.backpressure = bp;
Expand Down
9 changes: 1 addition & 8 deletions src/wpt/streams-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,6 @@ export default {
expectedFailures: [
'start: errors in start cause WritableStream constructor to throw',
'write: returning a rejected promise (second write) should cause writer write() and ready to reject',
'write: returning a promise that becomes rejected after the writer write() should cause writer write() and ready to reject',
],
},
'writable-streams/byte-length-queuing-strategy.any.js': {
Expand All @@ -764,7 +763,6 @@ export default {
'writable-streams/close.any.js': {
comment: 'To be investigated',
expectedFailures: [
'when close is called on a WritableStream in waiting state, ready promise should be fulfilled',
'releaseLock() should not change the result of sync close()',
],
},
Expand Down Expand Up @@ -817,10 +815,5 @@ export default {
"underlying sink's write or close should not be called if start throws",
],
},
'writable-streams/write.any.js': {
comment: 'To be investigated',
expectedFailures: [
'WritableStream should transition to waiting until write is acknowledged',
],
},
'writable-streams/write.any.js': {},
} satisfies TestRunnerConfig;