fix(artifacts): remove tokenExpiresAt from ArtifactsCreateRepoResult#6602
Open
mattzcarey wants to merge 1 commit intocloudflare:mainfrom
Open
fix(artifacts): remove tokenExpiresAt from ArtifactsCreateRepoResult#6602mattzcarey wants to merge 1 commit intocloudflare:mainfrom
mattzcarey wants to merge 1 commit intocloudflare:mainfrom
Conversation
The token itself encodes its expiry as `art_v1_<secret>?expires=<unix_seconds>`, making the separate `tokenExpiresAt` field redundant.
NuroDev
approved these changes
Apr 17, 2026
dom96
reviewed
Apr 17, 2026
| plaintext: string; | ||
| /** Token scope: "read" or "write". */ | ||
| scope: "read" | "write"; | ||
| /** ISO 8601 token expiry timestamp. */ |
Contributor
There was a problem hiding this comment.
Should these comments be deleted without removing the fields (more below)?
Member
There was a problem hiding this comment.
Good catch. +1 for keeping these doc comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
tokenExpiresAtfield fromArtifactsCreateRepoResult. The token itself encodes its expiry asart_v1_<secret>?expires=<unix_seconds>, making the separate field redundant.Companion PRs: