Skip to content

let rollout_step_percentage also accept an array of numbers#10337

Merged
dario-piotrowicz merged 9 commits intomainfrom
emily/rollout-steps
Aug 20, 2025
Merged

let rollout_step_percentage also accept an array of numbers#10337
dario-piotrowicz merged 9 commits intomainfrom
emily/rollout-steps

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen commented Aug 12, 2025

DEVX-2162 (not sure why jira created this as DEVX not CC...)

docs to come


@emily-shen emily-shen requested review from a team as code owners August 12, 2025 17:26
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 12, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/rollout-steps might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10337
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Aug 12, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10337

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10337

miniflare

npm i https://pkg.pr.new/miniflare@10337

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10337

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10337

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10337

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10337

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10337

wrangler

npm i https://pkg.pr.new/wrangler@10337

commit: 09668e7

Comment thread packages/wrangler/src/containers/deploy.ts Outdated
@emily-shen emily-shen force-pushed the emily/rollout-steps branch from ab12991 to 082832b Compare August 13, 2025 14:41
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 13, 2025

🦋 Changeset detected

Latest commit: 09668e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen force-pushed the emily/rollout-steps branch 2 times, most recently from 9916a21 to a3b9c00 Compare August 13, 2025 15:58
Comment thread .changeset/stupid-words-roll.md Outdated
Comment thread packages/wrangler/src/config/validation.ts
Comment thread packages/wrangler/src/__tests__/containers/deploy.test.ts Outdated
Copy link
Copy Markdown
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits, but LGTM otherwise

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 14, 2025
@emily-shen emily-shen added the blocked Blocked on other work label Aug 14, 2025
@emily-shen emily-shen force-pushed the emily/rollout-steps branch 2 times, most recently from 3d085b4 to 39eded5 Compare August 20, 2025 09:46
@emily-shen emily-shen force-pushed the emily/rollout-steps branch from 39eded5 to e96bd08 Compare August 20, 2025 17:07
@emily-shen emily-shen removed the blocked Blocked on other work label Aug 20, 2025
@dario-piotrowicz dario-piotrowicz merged commit f9f7519 into main Aug 20, 2025
59 of 72 checks passed
@dario-piotrowicz dario-piotrowicz deleted the emily/rollout-steps branch August 20, 2025 18:47
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 20, 2025
@dario-piotrowicz
Copy link
Copy Markdown
Member

For posterity: I Force-merged the PR although it was failing Wrangler e2e/start-worker-auth-opts tests on Windows and Linux, the same tests anyways work fine locally and they are also failing in the Versions PR: #10406 so these failures are most likely unrelated with the changes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants