fix: sanitize double-slashes in asset-worker redirects#10402
Merged
dario-piotrowicz merged 1 commit intocloudflare:mainfrom Aug 19, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: e271a93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0460eda to
f0d4edb
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
f0d4edb to
c8d6c8f
Compare
WillTaylorDev
approved these changes
Aug 18, 2025
dario-piotrowicz
approved these changes
Aug 19, 2025
A redirect rule such as: ``` /foo/* /:splat ``` And a request such as: ``` https://example.com/foo//google.com ``` Would result in a redirect target: ``` //google.com ``` Which would incorrectly resolve to: ``` https://google.com ``` When constructing a URL.
c8d6c8f to
e271a93
Compare
|
Congratulations @danielrs, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmeiq0cek068807kz3y1g1c9p This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A redirect rule such as:
And a request such as:
Would result in a redirect target:
Which would incorrectly resolve to:
When constructing a URL.
Problem was already patched in the live service.
Describe your change...