Skip to content

set default for rollout_active_grace_period#10407

Merged
emily-shen merged 2 commits intomainfrom
emily/grace-period-default
Aug 19, 2025
Merged

set default for rollout_active_grace_period#10407
emily-shen merged 2 commits intomainfrom
emily/grace-period-default

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

this should default to 0 if unset.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: documentation being done separately
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: new

@emily-shen emily-shen requested a review from a team as a code owner August 19, 2025 12:25
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 19, 2025

🦋 Changeset detected

Latest commit: cb143d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/grace-period-default might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10407
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Aug 19, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10407

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10407

miniflare

npm i https://pkg.pr.new/miniflare@10407

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10407

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10407

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10407

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10407

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10407

wrangler

npm i https://pkg.pr.new/wrangler@10407

commit: cb143d6

Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 19, 2025
@emily-shen emily-shen merged commit f534c0d into main Aug 19, 2025
37 of 38 checks passed
@emily-shen emily-shen deleted the emily/grace-period-default branch August 19, 2025 13:13
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants