Skip to content

Exclude Cloudflare built-ins from client dependency optimization#10415

Merged
jamesopstad merged 2 commits intomainfrom
james/exclude-cloudflare-builtins
Aug 20, 2025
Merged

Exclude Cloudflare built-ins from client dependency optimization#10415
jamesopstad merged 2 commits intomainfrom
james/exclude-cloudflare-builtins

Conversation

@jamesopstad
Copy link
Copy Markdown
Contributor

Fixes #000.

Some frameworks allow users to mix client and server code in the same file and then extract the server code.
As the dependency optimization may happen before the server code is extracted, we now exclude Cloudflare built-ins from client optimization.


  • Tests
    • Tests included
    • Tests not necessary because: not failing existing tests is enough
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a Wrangler change

@jamesopstad jamesopstad requested a review from a team August 20, 2025 11:49
@jamesopstad jamesopstad requested a review from a team as a code owner August 20, 2025 11:49
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 20, 2025

🦋 Changeset detected

Latest commit: d03690f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamesopstad jamesopstad added the vite-plugin Relating to the `@cloudflare/vite-plugin` package label Aug 20, 2025
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 20, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Aug 20, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10415

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10415

miniflare

npm i https://pkg.pr.new/miniflare@10415

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10415

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10415

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10415

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10415

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10415

wrangler

npm i https://pkg.pr.new/wrangler@10415

commit: d03690f

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 20, 2025
@jamesopstad jamesopstad merged commit 718fffc into main Aug 20, 2025
48 of 52 checks passed
@jamesopstad jamesopstad deleted the james/exclude-cloudflare-builtins branch August 20, 2025 16:15
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vite-plugin Relating to the `@cloudflare/vite-plugin` package

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants