Skip to content

log import code#10731

Merged
petebacondarwin merged 5 commits into
mainfrom
pbd/log-import-code
Sep 23, 2025
Merged

log import code#10731
petebacondarwin merged 5 commits into
mainfrom
pbd/log-import-code

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

Fixes #[insert GH or internal issue link(s)].

Describe your change...


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because:
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because:

@petebacondarwin petebacondarwin added the skip-pr-description-validation Skip validation of the required PR description format label Sep 23, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 23, 2025

⚠️ No Changeset found

Latest commit: 7311242

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Sep 23, 2025
@petebacondarwin petebacondarwin added the no-changeset-required Skip PR check for valid changeset label Sep 23, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Sep 23, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10731

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10731

miniflare

npm i https://pkg.pr.new/miniflare@10731

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10731

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10731

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10731

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10731

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10731

wrangler

npm i https://pkg.pr.new/wrangler@10731

commit: 7311242

@petebacondarwin petebacondarwin force-pushed the pbd/log-import-code branch 3 times, most recently from 5064ea4 to 849e972 Compare September 23, 2025 15:52
@petebacondarwin petebacondarwin marked this pull request as ready for review September 23, 2025 17:43
@petebacondarwin petebacondarwin requested a review from a team as a code owner September 23, 2025 17:43
@@ -44,20 +47,17 @@ function collectMessagesContaining<T>(
return collection;
}

describe("DevEnv", () => {
describe("DevEnv", { sequential: true }, () => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't running tests sequentially the default? 🤔
https://vitest.dev/guide/parallelism.html#test-parallelism

(maybe you intentionally want to make it extra clear/evident here?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was being super-cautious because I think it is possible to override the default at the config/CLI level.

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Sep 23, 2025
@petebacondarwin petebacondarwin merged commit 5f8155a into main Sep 23, 2025
29 checks passed
@petebacondarwin petebacondarwin deleted the pbd/log-import-code branch September 23, 2025 20:42
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changeset-required Skip PR check for valid changeset skip-pr-description-validation Skip validation of the required PR description format

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants