Skip to content

fix: improve error message when the entrypoint is incorrect#11350

Merged
petebacondarwin merged 2 commits intomainfrom
dario/DEVX-2304/wrangler-deploy-entrypoint-error-warning
Feb 3, 2026
Merged

fix: improve error message when the entrypoint is incorrect#11350
petebacondarwin merged 2 commits intomainfrom
dario/DEVX-2304/wrangler-deploy-entrypoint-error-warning

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Nov 19, 2025

Fixes https://jira.cfdata.org/browse/DEVX-2304

This PR simple slightly improves the wording of errors being thrown when an entrypoint configuration is incorrect, hopefully providing more clear and actionable errors to users.


  • Tests
    • Tests included/updated
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: UX improvement not requiring documentation

Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 19, 2025

🦋 Changeset detected

Latest commit: cd7bed1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Nov 19, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11350

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11350

miniflare

npm i https://pkg.pr.new/miniflare@11350

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11350

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11350

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11350

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11350

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11350

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11350

wrangler

npm i https://pkg.pr.new/wrangler@11350

commit: cd7bed1

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2304/wrangler-deploy-entrypoint-error-warning branch 2 times, most recently from c7164b0 to 869481a Compare November 24, 2025 18:31
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review November 25, 2025 12:57
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner November 25, 2025 12:57
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2304/wrangler-deploy-entrypoint-error-warning branch from 869481a to ae30da4 Compare November 26, 2025 16:59
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2304/wrangler-deploy-entrypoint-error-warning branch from ae30da4 to abf5042 Compare November 26, 2025 21:53
@petebacondarwin petebacondarwin force-pushed the dario/DEVX-2304/wrangler-deploy-entrypoint-error-warning branch from abf5042 to ddea7c3 Compare December 23, 2025 13:20
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Dec 23, 2025

Claude finished @dario-piotrowicz's task —— View job


Changeset Review

Reviewing changeset file .changeset/brave-geckos-juggle.md...

Todo List:

  • Read changeset guidelines from .changeset/README.md
  • Read the changeset file
  • Validate changeset content
  • Post review findings

Review Findings

⚠️ Issues found

The changeset has a formatting issue that should be addressed:

Title Format Issue:
The title uses a conventional commit prefix (fix:), which is acceptable per AGENTS.md, but it would be better without the prefix since this is the title that will appear in the changelog. The guidelines show examples without prefixes:

  • Current: fix: improve error message when the entrypoint is incorrect
  • Suggested: Improve error message when the entrypoint is incorrect

The body description is good - it clearly explains what was improved and the user benefit.

All other validation checks pass:

  • ✅ Version Type: patch is correct for a bug fix/improvement
  • ✅ Changelog Quality: Meaningful description with clear user benefit
  • ✅ Markdown Headers: No h1/h2/h3 headers present
  • ✅ Package Coverage: Correctly references wrangler
  • ✅ No analytics changes

Recommendation:
Consider removing the fix: prefix from the title to match the changeset guidelines' examples, though the current format is technically acceptable per the project's AGENTS.md file.

@petebacondarwin petebacondarwin force-pushed the dario/DEVX-2304/wrangler-deploy-entrypoint-error-warning branch from ddea7c3 to 8302cec Compare February 2, 2026 12:45
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 2, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional flags.

Open in Devin Review

Comment thread packages/wrangler/src/deployment-bundle/run-custom-build.ts Outdated
@cloudflare cloudflare deleted a comment from github-actions Bot Feb 2, 2026
@petebacondarwin
Copy link
Copy Markdown
Contributor

@dario-piotrowicz - approved but perhaps improve the changeset and fix the dedented indentation?

@petebacondarwin petebacondarwin force-pushed the dario/DEVX-2304/wrangler-deploy-entrypoint-error-warning branch from 8302cec to cd7bed1 Compare February 3, 2026 20:53
@petebacondarwin petebacondarwin merged commit ee9b81f into main Feb 3, 2026
43 of 44 checks passed
@petebacondarwin petebacondarwin deleted the dario/DEVX-2304/wrangler-deploy-entrypoint-error-warning branch February 3, 2026 22:10
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants