Skip to content

Un-quarantine the RedwoodSDK C3 e2e test and bump create-rwsdk to 3.1.1#11557

Merged
dario-piotrowicz merged 4 commits intomainfrom
dario/c3-quarantined-redwood
Dec 8, 2025
Merged

Un-quarantine the RedwoodSDK C3 e2e test and bump create-rwsdk to 3.1.1#11557
dario-piotrowicz merged 4 commits intomainfrom
dario/c3-quarantined-redwood

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Dec 8, 2025

This PR reverts the changes in #11554 since create-rwsdk@3.1.1 has been released

It also bumps the create-rwsdk version to 3.1.1


  • Tests
    • Tests included/updated
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tests change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a Wrangler change

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner December 8, 2025 14:11
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 8, 2025

🦋 Changeset detected

Latest commit: 925d9d0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamesopstad
Copy link
Copy Markdown
Contributor

Thanks. Could you address #11554 (comment) in this PR so we can do both changes in one?

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Dec 8, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11557

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11557

miniflare

npm i https://pkg.pr.new/miniflare@11557

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11557

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11557

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11557

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11557

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11557

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11557

wrangler

npm i https://pkg.pr.new/wrangler@11557

commit: 925d9d0

@dario-piotrowicz
Copy link
Copy Markdown
Member Author

Thanks. Could you address #11554 (comment) in this PR so we can do both changes in one?

right! done 🙂👍 3e0c76c

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Dec 8, 2025
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR update create-rwsdk as well ?

@dario-piotrowicz
Copy link
Copy Markdown
Member Author

dario-piotrowicz commented Dec 8, 2025

Should this PR update create-rwsdk as well ?

I think that it's not necessary.... but also yeah it wouldn't hurt 🙂👍

Yeah, definitely! thanks for pointing that out! 👍

@dario-piotrowicz dario-piotrowicz changed the title Un-quarantine the RedwoodSDK C3 e2e test Un-quarantine the RedwoodSDK C3 e2e test and bump create-rwsdk to 3.1.1 Dec 8, 2025
@dario-piotrowicz
Copy link
Copy Markdown
Member Author

Oh no.... it looks like something might be wrong with @petebacondarwin's fix 😓

Screenshot 2025-12-08 at 17 07 46

@dario-piotrowicz
Copy link
Copy Markdown
Member Author

Oh no.... it looks like something might be wrong with @petebacondarwin's fix 😓

Screenshot 2025-12-08 at 17 07 46

Ah ok that just got fixed 🙂
redwoodjs/create-rwsdk#5

@dario-piotrowicz dario-piotrowicz merged commit 632fb6d into main Dec 8, 2025
30 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Dec 8, 2025
@dario-piotrowicz dario-piotrowicz deleted the dario/c3-quarantined-redwood branch December 8, 2025 17:38
vicb added a commit that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants