Filter entry Worker config when passing to config function#11735
Merged
jamesopstad merged 3 commits intomainfrom Dec 22, 2025
Merged
Filter entry Worker config when passing to config function#11735jamesopstad merged 3 commits intomainfrom
config function#11735jamesopstad merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: e2a1678 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Claude finished @jamesopstad's task —— View job Reviewing Changesets
✅ All changesets look good The changeset follows all guidelines:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
ascorbic
reviewed
Dec 22, 2025
| function filterEntryWorkerConfig( | ||
| config: ResolvedAssetsOnlyConfig | ||
| ): FilteredEntryWorkerConfig { | ||
| // eslint-disable-next-line unused-imports/no-unused-vars |
Contributor
There was a problem hiding this comment.
I think there's a way to disable this rule for destructured object entries
Contributor
Author
There was a problem hiding this comment.
e2a1678 Removed eslint disable and added regression tests.
ascorbic
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
topLevelNameandnamewhen passingentryWorkerConfigto theconfigfunction for auxiliary Workers.The
namefor each Worker should be unique and thetopLevelNameis computed rather than provided directly.A picture of a cute animal (not mandatory, but encouraged)