Bump Chrome to 126.0.6478.182#11753
Merged
ruifigueira merged 4 commits intoMar 23, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 056c8ae The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Claude finished @ruifigueira's task —— View job Changeset Review✅ All changesets look good The changeset passes all validation criteria:
|
ruifigueira
force-pushed
the
rfigueira/BRAPI-756-reciprocate-brower-ws-close
branch
from
7136fda to
915e55d
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
ruifigueira
force-pushed
the
rfigueira/BRAPI-756-reciprocate-brower-ws-close
branch
2 times, most recently
from
fea7c8d to
5e0aed0
Compare
penalosa
force-pushed
the
rfigueira/BRAPI-756-reciprocate-brower-ws-close
branch
from
5e0aed0 to
0a633c5
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
✅ All changesets look good |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ruifigueira
force-pushed
the
rfigueira/BRAPI-756-reciprocate-brower-ws-close
branch
2 times, most recently
from
321fc43 to
c36868e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ruifigueira
changed the title
It's the corresponding chrome version for puppeteer 22.13.1 / @cloudflare/puppeteer 1.0.4. See: https://pptr.dev/supported-browsers#supported-browser-version-list Fixes: BRAPI-757
As long a worker websocket's close event calls the corresponding websocket close function, we ensure close event is called on the other end, and therefore we no longer need pollinh to check the browser process. See: cloudflare/workerd#4327 (comment)
ruifigueira
force-pushed
the
rfigueira/BRAPI-756-reciprocate-brower-ws-close
branch
from
c36868e to
361be25
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
penalosa
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BRAPI-756 and BRAPI-757
ws.close()inside ws close event, we no longer need to poll the browser process because the websocket on the other end now receives thecloseevent, as expected. Previous solution was a hack that is no longer needed.See: cloudflare/workerd#4327 (comment)
A picture of a cute animal (not mandatory, but encouraged)