fix(wrangler): Fixed invalid command / argument error logging by NuroDev · Pull Request #12050 · cloudflare/workers-sdk

NuroDev · 2026-01-22T15:39:00Z

Before

➜ wrangler foo --help
wrangler

COMMANDS
  wrangler docs [search..]        📚 Open Wrangler's command documentation in your browser

After

➜ wrangler foo --help

✘ [ERROR] Unknown argument: foo

wrangler

COMMANDS
  wrangler docs [search..]        📚 Open Wrangler's command documentation in your browser

Before

➜ ❯ wrangler types --hello

✘ [ERROR] Unknown argument: hello


wrangler

COMMANDS
  wrangler docs [search..]        📚 Open Wrangler's command documentation in your browser

After

➜ wrangler types --hello

✘ [ERROR] Unknown argument: hello


wrangler types [path]

📝 Generate types from your Worker configuration

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: Minor bug fix

A picture of a cute animal (not mandatory, but encouraged)

changeset-bot · 2026-01-22T15:39:05Z

🦋 Changeset detected

Latest commit: 3972091

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2026-01-22T15:42:33Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12050

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12050

miniflare

npm i https://pkg.pr.new/miniflare@12050

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12050

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12050

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12050

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12050

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12050

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12050

wrangler

npm i https://pkg.pr.new/wrangler@12050

commit: 3972091

devin-ai-integration

Devin Review found 1 potential issue.

View issue and 5 additional flags in Devin Review.

NuroDev · 2026-01-22T16:15:52Z

+	if (hasHelpFlag && subCommand) {
+		const knownCommands = registry.topLevelCommands;
+		if (!knownCommands.has(subCommand)) {
+			logger.info("");


This is here simply to appease formatting to match other errors by adding a spacing around the error.

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 5 additional flags in Devin Review.

This reverts commit 059bb56.

NuroDev · 2026-01-23T11:26:05Z

Spoke with @petebacondarwin yesterday about this and I'm going to put this PR on hold until #12055 is merged so this fix doesn't have to rely on legacy commands.

claude · 2026-01-28T15:33:40Z

Claude finished @NuroDev's task —— View job

Changeset Review

✅ All changesets look good

The changeset .changeset/dark-rocks-smoke.md is properly formatted:

Version type: patch ✅ (appropriate for bug fix)
Description quality: Clear explanation of what was fixed ✅
Markdown headers: None used ✅
Analytics: Not applicable ✅
Format: Follows the imperative style with good detail ✅

Cuteness Report

This is Snow Paws. Absolutely covered in winter's finest glitter and sporting those soulful amber eyes. Clearly just discovered that snow is wet and cold but remains optimistic about the situation. 14/10 would give all the treats.

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 12 additional flags in Devin Review.

dario-piotrowicz

Generally looks good to me 👍

Possibly I'd add a TODO comment or something like that around the legacy commands explaining why they haven't yet been updated and that we should do so.

Co-authored-by: Dario Piotrowicz <dario@cloudflare.com>

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 6 additional flags in Devin Review.

devin-ai-integration · 2026-01-30T11:29:40Z

+	const nonFlagArgs = argv.filter((arg) => !arg.startsWith("-"));
+	const isRootHelpRequest = hasHelpFlag && nonFlagArgs.length === 0;

-	const { wrangler, showHelpWithCategories } = createCLIParser(argv);
+	const { wrangler, registry, showHelpWithCategories } = createCLIParser(argv);

 	if (isRootHelpRequest) {
 		await showHelpWithCategories();
 		return;
 	}

+	// Check for unknown command with a `--help` flag
+	const [subCommand] = nonFlagArgs;
+	if (hasHelpFlag && subCommand) {
+		const knownCommands = registry.topLevelCommands;
+		if (!knownCommands.has(subCommand)) {
+			logger.info("");
+			logger.error(`Unknown argument: ${subCommand}`);
+			await showHelpWithCategories();
+			throw new CommandLineArgsError(`Unknown argument: ${subCommand}`);
+		}


🟡 Flag values are incorrectly identified as unknown commands when flags precede the command

When global flags like --config are placed before the command name, the flag's value is incorrectly identified as the subcommand.

Click to expand

Mechanism

The code at line 1888 filters argv using a simple string check !arg.startsWith("-") to identify positional arguments. This approach doesn't account for flag values that don't start with -.

For wrangler --config foo.toml deploy --help:

argv = ["--config", "foo.toml", "deploy", "--help"]

nonFlagArgs = ["foo.toml", "deploy"] (incorrectly includes foo.toml)

subCommand = "foo.toml"

Since "foo.toml" is not in knownCommands, the code throws Unknown argument: foo.toml

Actual vs Expected

Actual: Error "Unknown argument: foo.toml" is thrown

Expected: Help for the deploy command should be shown

Impact

This is a regression. Users who place global flags before the command name (which yargs normally supports) will now get confusing error messages about their config file paths being "unknown arguments" when using --help.

Recommendation: Consider using a smarter approach to identify the subcommand, such as: (1) skipping known global flag names and their values when filtering, (2) only considering the first argument that doesn't follow a known flag, or (3) using yargs' built-in parsing before this check.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 9 additional flags in Devin Review.

Added initial invalid command / flag fix

0903a18

NuroDev self-assigned this Jan 22, 2026

workers-devprod added this to workers-sdk Jan 22, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Jan 22, 2026

NuroDev changed the title ~~Added initial invalid command / flag fix~~ Fixed Wrangler invalid command / argument error logging Jan 22, 2026

NuroDev and others added 3 commits January 22, 2026 15:52

Added changeset

1ab388f

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

02364a9

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

152acd8

NuroDev marked this pull request as ready for review January 22, 2026 15:57

NuroDev requested a review from a team as a code owner January 22, 2026 15:57

devin-ai-integration Bot reviewed Jan 22, 2026

View reviewed changes

Comment thread packages/wrangler/src/index.ts

NuroDev added 2 commits January 22, 2026 16:04

Added empty line to unknown command with help flag

9e39b3f

Replaced CommandLineArgsError error with return statement

059bb56

NuroDev commented Jan 22, 2026

View reviewed changes

devin-ai-integration Bot reviewed Jan 22, 2026

View reviewed changes

Comment thread packages/wrangler/src/index.ts Outdated

vicb reviewed Jan 22, 2026

View reviewed changes

Comment thread packages/wrangler/src/core/CommandRegistry.ts

NuroDev and others added 4 commits January 22, 2026 16:23

Revert "Replaced CommandLineArgsError error with return statement"

47cc108

This reverts commit 059bb56.

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

5e81523

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

04e1372

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

5f7cdff

vicb mentioned this pull request Jan 23, 2026

refactor(wrangler): move telemetry events from yargs middleware to command handlers #12055

Closed

5 tasks

NuroDev marked this pull request as draft January 23, 2026 11:25

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

a7eb144

NuroDev added 3 commits January 29, 2026 11:26

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

5e2aac0

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

1bd3bbc

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

633a5dc

NuroDev changed the title ~~Fixed Wrangler invalid command / argument error logging~~ fix(wrangler): Fixed Wrangler invalid command / argument error logging Jan 29, 2026

NuroDev changed the title ~~fix(wrangler): Fixed Wrangler invalid command / argument error logging~~ fix(wrangler): Fixed invalid command / argument error logging Jan 29, 2026

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

1dd61d2

NuroDev marked this pull request as ready for review January 29, 2026 15:24

NuroDev enabled auto-merge January 29, 2026 15:48

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

b34431f

devin-ai-integration Bot reviewed Jan 29, 2026

View reviewed changes

Comment thread packages/wrangler/src/core/handle-errors.ts Outdated

NuroDev and others added 6 commits January 29, 2026 16:40

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

cafc550

Updated unknown arg regex to include commands

751da9b

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

91fbd08

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

2f13d0c

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

4b8bc63

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

e74a3e9

dario-piotrowicz approved these changes Jan 30, 2026

View reviewed changes

Comment thread packages/wrangler/src/__tests__/index.test.ts

Comment thread packages/wrangler/src/__tests__/index.test.ts

Comment thread packages/wrangler/src/__tests__/index.test.ts

Comment thread packages/wrangler/src/core/handle-errors.ts Outdated

auto-merge was automatically disabled January 30, 2026 10:48
Merge commits are not allowed on this repository

github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jan 30, 2026

NuroDev and others added 2 commits January 30, 2026 11:21

Apply suggestions from code review

dff5112

Co-authored-by: Dario Piotrowicz <dario@cloudflare.com>

Merge branch 'main' into NuroDev/fix-invalid-command-arg-errors

8928662

devin-ai-integration Bot reviewed Jan 30, 2026

View reviewed changes

Added doc comments to help menu tests

3972091

devin-ai-integration Bot reviewed Jan 30, 2026

View reviewed changes

Comment thread packages/wrangler/src/index.ts

NuroDev merged commit b05b919 into main Jan 30, 2026
37 checks passed

NuroDev deleted the NuroDev/fix-invalid-command-arg-errors branch January 30, 2026 12:00

github-project-automation Bot moved this from Approved to Done in workers-sdk Jan 30, 2026

workers-devprod mentioned this pull request Jan 30, 2026

Version Packages #12266

Merged

Conversation

NuroDev commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Before

After

Uh oh!

changeset-bot Bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new Bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NuroDev Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

NuroDev commented Jan 23, 2026

Uh oh!

claude Bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset Review

Cuteness Report

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Jan 30, 2026

Choose a reason for hiding this comment

Mechanism

Actual vs Expected

Impact

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NuroDev commented Jan 22, 2026 •

edited

Loading

changeset-bot Bot commented Jan 22, 2026 •

edited

Loading

pkg-pr-new Bot commented Jan 22, 2026 •

edited

Loading

claude Bot commented Jan 28, 2026 •

edited

Loading