fix(wrangler): show friendly error when D1 export output is a directory

[langningchen]

Fixes #7629

Currently, when running wrangler d1 export with a directory path passed to the --output flag, it throws a low-level Node.js EISDIR error. This PR adds a check to verify if the provided output path is a directory and throws a descriptive UserError instead.

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: This is a minor improvement to an internal error message and does not change the command's usage or API.

A picture of a cute animal

Furina de Fontaine is a playable Hydro character in Genshin Impact who can alternate between Pneuma and Ousia alignments.

---

[changeset-bot]

🦋 Changeset detected

Latest commit: 76d8846

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[devin-ai-integration]

Devin Review found 1 potential issue.

View issue and 1 additional flag in Devin Review.

[Copilot]

Pull request overview

Improves wrangler d1 export by replacing a low-level Node.js EISDIR error with a friendlier UserError when --output points to a directory.

Changes:

• Added a preflight --output path check intended to detect directory paths and throw a descriptive UserError.
• Updated a comment spelling in the local export implementation.
• Added a changeset for a patch release of wrangler.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
packages/wrangler/src/d1/export.ts	Adds --output directory detection to produce a friendly error message before attempting to write.
.changeset/cute-pets-fry.md	Records the user-facing change in a patch changeset.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[edmundhung]

Thanks for the PR! This should be testable. Take a look at packages/wrangler/src/tests/d1/ for examples of how D1 commands are tested. A test that verifies the error when --output is a directory would be a good addition. :)

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[langningchen]

@edmundhung Thanks for the feedback! I've updated the code to use statSync with throwIfNoEntry and added a test case in export.test.ts to cover this scenario. Local tests are now passing. Ready for another look!

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12065

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12065

miniflare

npm i https://pkg.pr.new/miniflare@12065

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12065

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12065

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12065

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12065

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12065

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12065

wrangler

npm i https://pkg.pr.new/wrangler@12065

commit: 76d8846

[langningchen]

Hi @edmundhung, sorry to bother you. I've updated the branch to keep it in sync with main. It seems the CI workflows are awaiting approval to run. Whenever you have a moment, could you please trigger them? Thanks!