Use hook filters by jamesopstad · Pull Request #12214 · cloudflare/workers-sdk

jamesopstad · 2026-01-28T18:03:30Z

Use Hook Filters to optimize plugin performance with Vite 8. This skips unnecessary Rust-to-JS calls with Rolldown powered Vite.

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: internal change

A picture of a cute animal (not mandatory, but encouraged)

changeset-bot · 2026-01-28T18:03:35Z

🦋 Changeset detected

Latest commit: 9af37dc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

claude · 2026-01-28T18:03:58Z

Claude finished @jamesopstad's task —— View job

Changeset Review

✅ All changesets look good

The changeset at .changeset/tough-views-make.md is well-formatted:

Version type: minor is appropriate for a performance optimization feature
Description: Clear and includes a link to the Hook Filters documentation
No markdown headers: ✓ (no h1/h2/h3 headers present)
Package: @cloudflare/vite-plugin is correctly specified

pkg-pr-new · 2026-01-28T18:07:12Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12214

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12214

miniflare

npm i https://pkg.pr.new/miniflare@12214

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12214

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12214

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12214

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12214

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12214

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12214

wrangler

npm i https://pkg.pr.new/wrangler@12214

commit: 9af37dc

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional flags.

petebacondarwin

A few non-blocking questions.

petebacondarwin · 2026-01-30T11:05:51Z

-			if (id === `\0${VIRTUAL_WORKER_ENTRY}`) {
-				const nodeJsCompat = ctx.getNodeJsCompat(this.environment.name);
+		load: {
+			filter: { id: virtualCloudflareLoadRE },


Are there other virtual modules that could trigger this filter but are not handled by the loader?

Could we lock down this filter even more so that it only triggers if the three handled virtual entry-points are loaded?

I think it's OK as the we are reserving the virtual:cloudflare/ prefix for virtual modules handled by this plugin.

petebacondarwin · 2026-01-30T11:12:06Z

+				id: [nodeBuiltinsRE, /^unenv\//, /^@cloudflare\/unenv-preset\//],
+			},
+			async handler(source, importer, options) {
+				const nodeJsCompat = ctx.getNodeJsCompat(this.environment.name);


No fallback filtering here?

I don't think it's needed here because it already returns early if there is no result:

workers-sdk/packages/vite-plugin-cloudflare/src/plugins/nodejs-compat.ts

Lines 116 to 121 in 0704c22

// See if we can map the `source` to a Node.js compat alias.

const result = nodeJsCompat.resolveNodeJsImport(source);

if (!result) {

return;

}

workers-devprod added this to workers-sdk Jan 28, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Jan 28, 2026

jamesopstad force-pushed the james/hook-filters branch 2 times, most recently from 74deed5 to 0704c22 Compare January 28, 2026 20:02

jamesopstad marked this pull request as ready for review January 28, 2026 20:08

jamesopstad requested a review from a team as a code owner January 28, 2026 20:08

devin-ai-integration Bot reviewed Jan 28, 2026

View reviewed changes

petebacondarwin approved these changes Jan 30, 2026

View reviewed changes

github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jan 30, 2026

jamesopstad added 7 commits January 30, 2026 12:19

Update hooks to use object form

7470c0c

Use hook filters in virtual-modules plugins

ca96de4

Use hook filters in wasm plugin

65f0d6b

Use hook filters in additional modules plugin

a44d366

Use hook filters in Node.js compat plugins

7534405

Add changeset

e2d996d

Use fallback approach in virtualClientFallbackPlugin

9af37dc

jamesopstad force-pushed the james/hook-filters branch from 0704c22 to 9af37dc Compare January 30, 2026 12:20

jamesopstad merged commit 4db3864 into main Jan 30, 2026
37 checks passed

github-project-automation Bot moved this from Approved to Done in workers-sdk Jan 30, 2026

jamesopstad deleted the james/hook-filters branch January 30, 2026 12:52

workers-devprod mentioned this pull request Jan 30, 2026

Version Packages #12266

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use hook filters#12214

Use hook filters#12214
jamesopstad merged 7 commits intomainfrom
james/hook-filters

jamesopstad commented Jan 28, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

changeset-bot Bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

petebacondarwin left a comment

Uh oh!

petebacondarwin Jan 30, 2026

Uh oh!

jamesopstad Jan 30, 2026

Uh oh!

Uh oh!

petebacondarwin Jan 30, 2026

Uh oh!

jamesopstad Jan 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// See if we can map the `source` to a Node.js compat alias.
	const result = nodeJsCompat.resolveNodeJsImport(source);

	if (!result) {
	return;
	}

Conversation

jamesopstad commented Jan 28, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

claude Bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset Review

Uh oh!

pkg-pr-new Bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

jamesopstad Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

petebacondarwin Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

jamesopstad Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jamesopstad commented Jan 28, 2026 •

edited by devin-ai-integration Bot

Loading

changeset-bot Bot commented Jan 28, 2026 •

edited

Loading

claude Bot commented Jan 28, 2026 •

edited

Loading

pkg-pr-new Bot commented Jan 28, 2026 •

edited

Loading