Conversation
🦋 Changeset detectedLatest commit: 0a03c9e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @elithrar's task —— View job Changeset Review
✅ All changesets look good The changeset
The changeset follows the recommended format with a clear title and informative body that explains both what the change does and why it's valuable for users. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Generate the compatibility_date at project creation time rather than using a hardcoded date, ensuring new projects always have a current compatibility date in the example.
MattieTK
left a comment
MattieTK
left a comment
There was a problem hiding this comment.
Have modified the code to use today's date rather than a fixed date or the workerd compatibility date..
Aligning it with wrangler.jsonc would require threading the project path through multiple layers or refactoring the CLI flow, adding complexity for no real benefit at this point.
MattieTK
added
the
skip-pr-description-validation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…e, offer the user to skip agents.md creation
MattieTK
force-pushed
the
add-agents-md-to-templates
branch
from
71a28d8 to
97de148
Compare
|
@vicb I've refactored and tested this to work using the latest workerd specified compatibility date |
add --no-agents to most template tests
| await npmInstall(ctx); | ||
| await rectifyPmMismatch(ctx); | ||
|
|
||
| // Offer AGENTS.md for Workers templates that don't use a framework CLI |
There was a problem hiding this comment.
"that don't use a framework CLI"
Next doesn't use a framework CLI but still is a framework.
So I guess we should update this to say "framework" (no CLI) and make sure the behavior is correct for next
There was a problem hiding this comment.
good point, I'll do and verify that
There was a problem hiding this comment.
workers-sdk/packages/create-cloudflare/templates/next/c3.ts
Lines 23 to 24 in 3069655
I think nextjs is included even though we don't run it as the other frameworks. So this is covered.
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
Thanks for the updates
See my inline comments
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
Thanks for the updates.
Also thanks for reminding me about jsonc... atsro repo, I'm coming!
6 participants
Adds an AGENTS.md to non-framework templates (for now) that guides agents to focus on docs search and retrieval due to knowledge cut-offs and potentially stale usage of APIs, best practices, and Node.js compat in Workers.
Open questions:
package.jsonscript - e.g.npm run update-agents-mdthat fetches an updated copy from this repo?wrangler agentsorwrangler updatethat updates wrangler and theAGENTS.mdfile as well?Note that the AGENTS.md here is intentionally designed to be long-lived and minimize 'staleness' itself.