[explorer] add the UI for the dev resource explorer#12288
Conversation
🦋 Changeset detectedLatest commit: 5c0725b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d3c9e76 to
7aee498
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
b477054 to
5bb76f9
Compare
|
Claude finished @emily-shen's task —— View job Changeset ReviewReviewing changeset files... Todos:
Changeset:
|
9709bce to
eedfbc7
Compare
5a73021 to
c7b1c8a
Compare
There was a problem hiding this comment.
Would be better to try and get the icons to match the Cloudflare dashboard or workers.cloudflare.com if possible?
There was a problem hiding this comment.
the KV icon is taken from the dash, and i think the rest are generic enough not to matter?
There was a problem hiding this comment.
For consistency sake I would say it would be better but I'll let you make the call.
I just think for adding future icons it'd be easier to use the same packaged icon library than adding SVGs one-by-one.
There was a problem hiding this comment.
the icon library is in kumo so we would have to migrate anyway
| const [copied, setCopied] = useState(false); | ||
|
|
||
| const handleCopy = async () => { | ||
| await navigator.clipboard.writeText(text); |
There was a problem hiding this comment.
While unlikely, can we wrap this in a try / catch so if it does fail to write the text to clipboard we don't lie to the user saying it did.
There was a problem hiding this comment.
it won't right? if that line throws, it won't set copied to true?
There was a problem hiding this comment.
Yeah but if it does throw (Again, unlikely but could happen) do we not want to warn the user that them clicking the "Copy to clipboard" failed?
There was a problem hiding this comment.
Would it not be easier to use Tailwind CSS here as it would make migrating existing migrating existing internal styles easier, no?
There was a problem hiding this comment.
i don't think it'll make a difference when we switch to kumo components as they bring the tailwind styling with them. kumo also doesn't use tailwind classes directly, it has its own semantic class extensions, so if we used plain tailwind we would have to refactor it anyway.
the only advantage to using tailwind now would be if it was just nicer to develop with tailwind, and i don't (personally) think its worth it. tailwind makes the rest of the code more unreadable, in exchange for ergonomics when writing css. as i'm not really writing css by hand (thanks ai), that doesn't really matter (to me) anymore. happy to hear arguments against.
26c5e4a to
ed973d9
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
I know nothing about React 😅 but this LGTM
339ff68 to
159ab3a
Compare
- Add Sidebar component with KV namespace list - Add root layout with sidebar and main content area - Add index page with welcome message - Add base CSS with design tokens and shared styles - Add layout CSS for sidebar and breadcrumbs - Add Cloudflare logo SVG
actually a great catch from devin
159ab3a to
5c0725b
Compare
a lot of generated files again, diff looks scarier than it is!
This PR adds a UI which lets you view/edit KV namespaces
Currently looks something like this:

How this works:
This is not being served by miniflare - follow the instructions in the readme to test.
The next PR will make miniflare serve the built output on
/cdn-cgi/explorerA picture of a cute animal (not mandatory, but encouraged)