Skip to content

Simplify creating a new Astro app#12291

Merged
vicb merged 4 commits intomainfrom
vicb/c3-astro
Feb 2, 2026
Merged

Simplify creating a new Astro app#12291
vicb merged 4 commits intomainfrom
vicb/c3-astro

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Jan 29, 2026

Partially address #12198
There is more to the issue so it should stay opened.

This PR passes --no-git to create-astro because c3 handles that
It also removes extra flags from the tests (--no-git added here, and --no-install that was already used)

I ran into some issues validating this PR, discussed internally with the Astro team


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: fixes

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@vicb vicb requested a review from a team as a code owner January 29, 2026 19:49
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 29, 2026

🦋 Changeset detected

Latest commit: e747e2d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jan 29, 2026

Claude finished @vicb's task —— View job


Changeset Review

  • Read changeset guidelines
  • Review changeset file
  • Check for cute animal
  • Provide feedback

All changesets look good

The changeset in .changeset/forty-yaks-trade.md meets all requirements:

  • Version Type: patch is appropriate for this improvement to the Astro project creation flow
  • Changelog Quality: Clear description explaining what was changed and why (preventing duplicate git setup prompts)
  • Markdown Headers: No problematic h1/h2/h3 headers present
  • Format: Follows the proper format with a clear title and explanatory body

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional flags.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jan 30, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12291

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12291

miniflare

npm i https://pkg.pr.new/miniflare@12291

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12291

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12291

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12291

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12291

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12291

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12291

wrangler

npm i https://pkg.pr.new/wrangler@12291

commit: e747e2d

@vicb vicb requested a review from ascorbic January 30, 2026 15:38
"--typescript",
"strict",
],
flags: ["--skip-houston", "--template", "blog", "--typescript", "strict"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the changes in the test config?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically because --no-git and --no-install are now the default, they do not need to be repeated here.

#12198 has some details

Copy link
Copy Markdown
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but with a question about the tests

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 2, 2026
@vicb vicb merged commit 75062fe into main Feb 2, 2026
40 checks passed
@vicb vicb deleted the vicb/c3-astro branch February 2, 2026 09:42
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants