Conversation
🦋 Changeset detectedLatest commit: e747e2d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Claude finished @vicb's task —— View job Changeset Review
✅ All changesets look good The changeset in
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
ascorbic
reviewed
Feb 2, 2026
| "--typescript", | ||
| "strict", | ||
| ], | ||
| flags: ["--skip-houston", "--template", "blog", "--typescript", "strict"], |
Contributor
There was a problem hiding this comment.
Can you explain the changes in the test config?
Contributor
Author
There was a problem hiding this comment.
Basically because --no-git and --no-install are now the default, they do not need to be repeated here.
#12198 has some details
ascorbic
approved these changes
Feb 2, 2026
Contributor
ascorbic
left a comment
There was a problem hiding this comment.
Approving, but with a question about the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially address #12198
There is more to the issue so it should stay opened.
This PR passes
--no-gittocreate-astrobecause c3 handles thatIt also removes extra flags from the tests (
--no-gitadded here, and--no-installthat was already used)I ran into some issues validating this PR, discussed internally with the Astro team
A picture of a cute animal (not mandatory, but encouraged)