Improve autoconfig telemetry with granular event tracking#12307
Improve autoconfig telemetry with granular event tracking#12307dario-piotrowicz merged 17 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: ef3b5f3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @dario-piotrowicz's task —— View job Changeset ReviewReviewing changeset files for this PR... Todo List
Review Results.changeset/cool-webs-switch.mdIssue: Incorrect version type - should be minor, not patch Reasoning: According to the custom instructions:
This changeset adds new telemetry events to track the autoconfig workflow. This is collecting more analytics, which means it should be a minor version bump, not a patch. The changeset currently specifies Actually, upon re-reading, this changeset is already marked as minor. This is correct. .changeset/dull-clubs-exist.mdThis changeset is marked as minor and includes common telemetry properties in ad-hoc events. Since this expands analytics collection, minor is appropriate. The description is clear and detailed. ✅ Wait, let me re-validate both changesets more carefully: .changeset/cool-webs-switch.md ✅
.changeset/dull-clubs-exist.md ✅
✅ All changesets look good Both changesets are properly formatted, use the correct version type (minor for analytics-related changes), and provide clear, meaningful descriptions. Cuteness Report: This is Orange Dot. They're very small and very round. Possibly a sun or maybe a tangerine in witness protection. 11/10 would squint at again. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
dario-piotrowicz
force-pushed
the
dario/DEVX-2391/autoconf-telemetry
branch
from
586b00b to
1940ebb
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| } | ||
| } catch (error) { | ||
| sendMetricsEvent( | ||
| "autoconfig_configuration_completed", |
There was a problem hiding this comment.
IIRC wrangler command have an "...errored" event. Would it make sense here?
I ss success: false but maybe consistency is more important? If not maybe add a comment with the rationale
There was a problem hiding this comment.
Thanks! This is a bit of an argument of data schema design: do we have lots of explicit events with their own schemas, or do we have fewer events with consolidated schemas that handle more outcomes. I'm of the second school, and though we have events in the first school already, I would argue we should move towards the second school as this is generally the advice provided by modern analytics platforms for managing this kind of state. High cardinality properties are the way we make it easy to analyse funnels, and comparisons of outcomes inside the same event (eg, how many completed successfully vs how many for each error type).
dario-piotrowicz
force-pushed
the
dario/DEVX-2391/autoconf-telemetry
branch
from
afd20b8 to
4247bb5
Compare
dario-piotrowicz
force-pushed
the
dario/DEVX-2391/autoconf-telemetry
branch
from
4247bb5 to
73bdb50
Compare
5 participants
Fixes https://jira.cfdata.org/browse/DEVX-2391
Adds detailed telemetry events to track the autoconfig workflow, including process start/end, detection, and configuration phases. Each event includes a unique session ID (
appId), CI detection, framework information, and success/error status to help diagnose issues and understand usage patterns.A picture of a cute animal (not mandatory, but encouraged)