Skip to content

Always emit a .assetsignore file in the client output directory#12358

Merged
jamesopstad merged 3 commits intomainfrom
james/assets-ignore
Feb 2, 2026
Merged

Always emit a .assetsignore file in the client output directory#12358
jamesopstad merged 3 commits intomainfrom
james/assets-ignore

Conversation

@jamesopstad
Copy link
Copy Markdown
Contributor

@jamesopstad jamesopstad commented Feb 2, 2026

Always emit a .assetsignore file in the client output directory.

Previously, we would emit a .assetsignore file in the client output directory only if the client output included a wrangler.json file.
We now always emit it, which prevents a wrangler.json file being deployed as an asset if it is copied into this directory by mistake.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: N/A

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@jamesopstad jamesopstad requested a review from a team as a code owner February 2, 2026 10:11
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 2, 2026

🦋 Changeset detected

Latest commit: 5514f26

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Feb 2, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 2, 2026

Claude finished @jamesopstad's task —— View job


Changeset Review

✅ All changesets look good

The changeset .changeset/grumpy-nails-care.md is well-formatted and follows all guidelines:

  • Version Type: patch - Correct for a bug fix that prevents incorrect deployment behavior
  • Changelog Quality: Clear title and explanation of the change with before/after context
  • Markdown Headers: No problematic headers used ✓
  • Package Coverage: Correctly references @cloudflare/vite-plugin

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 2, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12358

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12358

miniflare

npm i https://pkg.pr.new/miniflare@12358

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12358

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12358

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12358

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12358

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12358

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12358

wrangler

npm i https://pkg.pr.new/wrangler@12358

commit: 5514f26

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional flags.

Open in Devin Review

Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 2, 2026
@jamesopstad jamesopstad merged commit 4340c42 into main Feb 2, 2026
37 of 38 checks passed
@jamesopstad jamesopstad deleted the james/assets-ignore branch February 2, 2026 14:08
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants