feat: use proxy shared secret in vite plugin#12393
Merged
jamesopstad merged 3 commits intocloudflare:mainfrom Feb 6, 2026
Merged
feat: use proxy shared secret in vite plugin#12393jamesopstad merged 3 commits intocloudflare:mainfrom
jamesopstad merged 3 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 501a9c0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
This seems like a good fix to me
jamesopstad
reviewed
Feb 6, 2026
Contributor
jamesopstad
left a comment
There was a problem hiding this comment.
Thanks a lot for the contribution! This is something we had been meaning to do and hadn't got to. I'll approve once you've made the suggested changes.
Contributor
Author
|
applied your suggestions! |
jamesopstad
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bit of a rabbit hole, I started by figuring out why the Host header while using vite plugin was different. I saw that
wrangler devdoesn't have this issue, and traced it to this code in wrangler is implementationhttps://github.com/cloudflare/workers-sdk/blob/main/packages/miniflare/src/workers/core/entry.worker.ts#L110-L113
with some figuring out, I found that wrangler used a shared proxy secret which in turn allows
entry.worker.tsto rewrite the Host header to the url. So I did the same in the vite plugin.this required me to drill through the plugin context to bunch of places, I didn't just pass the secret because just having
ctxwould be useful for other things in future. And with that, the Entry Worker now trusts vite's handler and I get my correct Host header.Here is a reproduction of the issue: https://github.com/BlankParticle/cf-vite-plugin-host-header-reproduction
related #10884
A picture of a cute animal (not mandatory, but encouraged)
