Skip to content

refactor: minor updates to fixture tests#12397

Merged
vicb merged 2 commits intomainfrom
vicb/12385-follow-ups
Feb 3, 2026
Merged

refactor: minor updates to fixture tests#12397
vicb merged 2 commits intomainfrom
vicb/12385-follow-ups

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Feb 3, 2026

This is a follow up for #12385

  • fix 2 errors reported by devin
  • refactor code according to Pete's suggestion.

The updates are for the open left opened on #12385


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not user facing, refactor

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 3, 2026

⚠️ No Changeset found

Latest commit: 078a1a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional flags.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 3, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12397

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12397

miniflare

npm i https://pkg.pr.new/miniflare@12397

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12397

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12397

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12397

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12397

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12397

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12397

wrangler

npm i https://pkg.pr.new/wrangler@12397

commit: 078a1a8

cacheType === "default"
? caches.default
: await caches.open("my-cache");
testNoOpCache(cache);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL!

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 3, 2026
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Feb 3, 2026

Thanks for the review Pete!

@vicb vicb merged commit 00a40ad into main Feb 3, 2026
39 of 44 checks passed
@vicb vicb deleted the vicb/12385-follow-ups branch February 3, 2026 21:09
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants