[create-cloudflare] Enable nodejs_compat by default for new projects#12399
[create-cloudflare] Enable nodejs_compat by default for new projects#12399petebacondarwin wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: 66c441e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @petebacondarwin's task —— View job Changeset Review✅ All changesets look good The changeset
The changeset properly explains the change, provides context on why it's helpful ("many npm packages require Node.js compatibility"), and includes a clear example of how users can opt-out if needed. |
Refs #8310
This PR implements @penalosa's suggestion from PR #8310 to automatically add
nodejs_compatvia C3 rather than manually adding it to each template.Instead of modifying every template's
wrangler.jsoncfile, this change adds thenodejs_compatflag automatically in C3'supdateWranglerConfigfunction when creating new projects. This approach:nodejs_compatif it ornodejs_compat_v2is already presentDevin PR requested by @petebacondarwin
Link to Devin run: https://app.devin.ai/sessions/7a606cdbe6d148a48d02975f027bf808
Human review checklist:
addNodejsCompatFlagandaddNodejsCompatFlagToTomlcorrectly handles edge cases