[explorer] make the favicon an outline#12414
Conversation
🦋 Changeset detectedLatest commit: 24ff4e0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @emily-shen's task —— View job Changeset Review
✅ All changesets look good The changeset correctly:
|
There was a problem hiding this comment.
Devin Review found 1 potential issue.
🟡 1 issue in files not directly in the diff
🟡 Stroke-based favicon may be clipped because stroke extends beyond the SVG viewBox bounds (packages/local-explorer-ui/public/favicon.svg:1-2)
The favicon SVG was changed from a filled path to an outlined path by setting stroke-width="3" and fill="none" on the root <svg>.
Because SVG strokes are centered on the path, a 3px stroke adds ~1.5px of geometry outside the original path bounds. The path includes coordinates on the edges of the viewBox (e.g. it reaches x=0/y=0), so the stroke can render outside the viewBox="0 0 66 30" and get clipped during rasterization (common for favicons).
Actual: parts of the outline can appear cut off at the top/left/bottom edges in some browsers/icon generators.
Expected: the full outline should remain visible.
Where this happens
packages/local-explorer-ui/public/favicon.svg:1-2
<svg ... viewBox="0 0 66 30" stroke-width="3" fill="none" ...>
<path d="... 0 28.133 ... 35.367 0 ..." />
</svg>Recommendation: Increase the viewBox padding (e.g. viewBox="-2 -2 70 34") and/or add overflow="visible", or reduce stroke-width so the outline doesn’t clip when rasterized for favicon sizes.
View issue and 3 additional flags in Devin Review.
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Remove the changeset? |
what do we think:
A picture of a cute animal (not mandatory, but encouraged)