Skip to content

[explorer] make the favicon an outline#12414

Merged
emily-shen merged 1 commit intomainfrom
emily/favicon
Feb 5, 2026
Merged

[explorer] make the favicon an outline#12414
emily-shen merged 1 commit intomainfrom
emily/favicon

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen commented Feb 4, 2026

what do we think:

Screenshot 2026-02-04 at 16 51 13
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: its a favicon
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: its a favicon

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@emily-shen emily-shen requested a review from a team as a code owner February 4, 2026 16:52
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 4, 2026

🦋 Changeset detected

Latest commit: 24ff4e0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 4, 2026

Claude finished @emily-shen's task —— View job


Changeset Review

  • Read changeset guidelines
  • Review changeset file
  • Check for cute animal

✅ All changesets look good

The changeset correctly:

  • Uses patch version (appropriate for a UI asset change)
  • Provides a clear description of what changed
  • Notes this is for an experimental project
  • Contains no markdown header violations
  • Affects the correct package (@cloudflare/local-explorer-ui)

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

🟡 1 issue in files not directly in the diff

🟡 Stroke-based favicon may be clipped because stroke extends beyond the SVG viewBox bounds (packages/local-explorer-ui/public/favicon.svg:1-2)

The favicon SVG was changed from a filled path to an outlined path by setting stroke-width="3" and fill="none" on the root <svg>.

Because SVG strokes are centered on the path, a 3px stroke adds ~1.5px of geometry outside the original path bounds. The path includes coordinates on the edges of the viewBox (e.g. it reaches x=0/y=0), so the stroke can render outside the viewBox="0 0 66 30" and get clipped during rasterization (common for favicons).

Actual: parts of the outline can appear cut off at the top/left/bottom edges in some browsers/icon generators.
Expected: the full outline should remain visible.

Where this happens

packages/local-explorer-ui/public/favicon.svg:1-2

<svg ... viewBox="0 0 66 30" stroke-width="3" fill="none" ...>
  <path d="... 0 28.133 ... 35.367 0 ..." />
</svg>

Recommendation: Increase the viewBox padding (e.g. viewBox="-2 -2 70 34") and/or add overflow="visible", or reduce stroke-width so the outline doesn’t clip when rasterized for favicon sizes.

View issue and 3 additional flags in Devin Review.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 4, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12414

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12414

miniflare

npm i https://pkg.pr.new/miniflare@12414

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12414

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12414

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12414

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12414

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12414

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12414

wrangler

npm i https://pkg.pr.new/wrangler@12414

commit: 24ff4e0

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 4, 2026
@vicb
Copy link
Copy Markdown
Contributor

vicb commented Feb 5, 2026

what do we think:

Remove the changeset?

@emily-shen emily-shen merged commit de473c2 into main Feb 5, 2026
43 of 46 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 5, 2026
@emily-shen emily-shen deleted the emily/favicon branch February 5, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants