Skip to content

Revert "WC-4389 Reduce ttl to 10s for asset-worker"#12416

Merged
petebacondarwin merged 1 commit intomainfrom
willtaylor/wc-4456-revert-ttl
Feb 5, 2026
Merged

Revert "WC-4389 Reduce ttl to 10s for asset-worker"#12416
petebacondarwin merged 1 commit intomainfrom
willtaylor/wc-4456-revert-ttl

Conversation

@WillTaylorDev
Copy link
Copy Markdown
Contributor

@WillTaylorDev WillTaylorDev commented Feb 5, 2026

This reverts commit 9a27dc2.

Fixes WC-4456

Describe your change...


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows: n/a
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a

A picture of a cute animal (not mandatory, but encouraged)
image


Open with Devin

@WillTaylorDev WillTaylorDev requested review from a team as code owners February 5, 2026 01:30
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 5, 2026

🦋 Changeset detected

Latest commit: f9ccce7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View issue and 3 additional flags in Devin Review.

Open in Devin Review

Comment thread packages/workers-shared/asset-worker/tests/kv.test.ts Outdated
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 5, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12416

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12416

miniflare

npm i https://pkg.pr.new/miniflare@12416

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12416

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12416

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12416

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12416

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12416

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12416

wrangler

npm i https://pkg.pr.new/wrangler@12416

commit: f9ccce7

Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 5, 2026
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-4456-revert-ttl branch from f87850d to b3fbeb4 Compare February 5, 2026 01:50
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 5, 2026

Claude finished @WillTaylorDev's task —— View job


Changeset Review

Reviewing changeset files...

  • Read changeset guidelines
  • Review .changeset/quiet-moose-judge.md
  • Validate against criteria
  • Check for cute animals

All changesets look good

The changeset correctly:

  • Uses patch version type (appropriate for reverting a change)
  • Provides a clear description of what's being reverted
  • Uses proper formatting without h1/h2/h3 headers
  • Targets the correct package (@cloudflare/workers-shared)

Cuteness Report

This is Pebbles. They're wearing a delightful blue tutu on the beach and absolutely rocking it. Clearly living their best penguin life. 14/10 would give all the fish.


@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-4456-revert-ttl branch from b3fbeb4 to f9ccce7 Compare February 5, 2026 01:53
@petebacondarwin petebacondarwin merged commit 38ad241 into main Feb 5, 2026
41 of 42 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 5, 2026
@petebacondarwin petebacondarwin deleted the willtaylor/wc-4456-revert-ttl branch February 5, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants