Skip to content

Always use forward slashes for python workers path handling#12421

Merged
vicb merged 8 commits intomainfrom
gyeongjae/windows-path-handling
Feb 5, 2026
Merged

Always use forward slashes for python workers path handling#12421
vicb merged 8 commits intomainfrom
gyeongjae/windows-path-handling

Conversation

@ryanking13
Copy link
Copy Markdown
Contributor

@ryanking13 ryanking13 commented Feb 5, 2026

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation

This fixes incorrect path handling in deploying python workers in windows environment. We I try to deploy Python workers in windows environment, the path separator in windows \ is not considered as a proper path separator and the whole full path is considered as a single file. This PR fixes it.


Open with Devin

@ryanking13 ryanking13 requested a review from a team as a code owner February 5, 2026 09:17
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 5, 2026

🦋 Changeset detected

Latest commit: 17d53ea

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 5, 2026

Claude finished @ryanking13's task —— View job


Changeset Review

Reviewing changeset file...

  • Read changeset guidelines
  • Review .changeset/young-vans-reply.md
  • Validate against criteria

✅ All changesets look good

The changeset .changeset/young-vans-reply.md is well-formatted and follows all guidelines:

  • ✅ Version type: patch is correct for a bug fix
  • ✅ Changelog quality: Clear description with good context (explains symptom, cause, and resolution)
  • ✅ No h1/h2/h3 headers: Uses plain paragraphs
  • ✅ No analytics changes
  • ✅ Not a dependabot PR
  • ✅ Not an experimental feature

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 5, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12421

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12421

miniflare

npm i https://pkg.pr.new/miniflare@12421

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12421

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12421

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12421

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12421

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12421

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12421

wrangler

npm i https://pkg.pr.new/wrangler@12421

commit: 17d53ea

Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comment

Comment thread packages/wrangler/src/deployment-bundle/find-additional-modules.ts
@github-project-automation github-project-automation Bot moved this from Untriaged to In Review in workers-sdk Feb 5, 2026
@ryanking13 ryanking13 requested a review from vicb February 5, 2026 10:01
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the update @ryanking13

@github-project-automation github-project-automation Bot moved this from In Review to Approved in workers-sdk Feb 5, 2026
@vicb vicb merged commit 937425c into main Feb 5, 2026
42 of 45 checks passed
@vicb vicb deleted the gyeongjae/windows-path-handling branch February 5, 2026 13:17
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants