You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Generated files got out of sync due to an incorrectly resolved merge conflict. i've added a CI check to make sure the generation steps are no-ops (ie up to date), the generation step is very fast (like 1s) so we don't need to worry about it.
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows:
Additional testing not necessary because: CI change
Public documentation
Cloudflare docs PR(s):
Documentation not necessary because: internal
A picture of a cute animal (not mandatory, but encouraged)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Generated files got out of sync due to an incorrectly resolved merge conflict. i've added a CI check to make sure the generation steps are no-ops (ie up to date), the generation step is very fast (like 1s) so we don't need to worry about it.
Could those files be generated on npm i instead?
Looks like there is already a generate:api script (called on build)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated files got out of sync due to an incorrectly resolved merge conflict. i've added a CI check to make sure the generation steps are no-ops (ie up to date), the generation step is very fast (like 1s) so we don't need to worry about it.
A picture of a cute animal (not mandatory, but encouraged)