Skip to content

Fix out-of-sync generated files#12423

Merged
emily-shen merged 1 commit intomainfrom
emily/regenerate
Feb 5, 2026
Merged

Fix out-of-sync generated files#12423
emily-shen merged 1 commit intomainfrom
emily/regenerate

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen commented Feb 5, 2026

Generated files got out of sync due to an incorrectly resolved merge conflict. i've added a CI check to make sure the generation steps are no-ops (ie up to date), the generation step is very fast (like 1s) so we don't need to worry about it.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: CI change
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@emily-shen emily-shen requested a review from a team as a code owner February 5, 2026 10:46
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 5, 2026

⚠️ No Changeset found

Latest commit: b956812

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Feb 5, 2026

Fixes #12420

Generated files got out of sync due to an incorrectly resolved merge conflict. i've added a CI check to make sure the generation steps are no-ops (ie up to date), the generation step is very fast (like 1s) so we don't need to worry about it.

Could those files be generated on npm i instead?

Looks like there is already a generate:api script (called on build)

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 5, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12423

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12423

miniflare

npm i https://pkg.pr.new/miniflare@12423

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12423

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12423

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12423

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12423

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12423

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12423

wrangler

npm i https://pkg.pr.new/wrangler@12423

commit: b956812

@emily-shen
Copy link
Copy Markdown
Contributor Author

emily-shen commented Feb 5, 2026

TODO: uncheck in these generated files in a followup. see #12420

@emily-shen emily-shen merged commit 4caad0d into main Feb 5, 2026
35 checks passed
@emily-shen emily-shen deleted the emily/regenerate branch February 5, 2026 11:30
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in workers-sdk Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants