Skip to content

Add framework selection prompt during autoconfig#12479

Merged
dario-piotrowicz merged 1 commit intomainfrom
dario/DEVX-2457/autoconfig-edit-framework
Feb 9, 2026
Merged

Add framework selection prompt during autoconfig#12479
dario-piotrowicz merged 1 commit intomainfrom
dario/DEVX-2457/autoconfig-edit-framework

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Feb 7, 2026

Fixes https://jira.cfdata.org/browse/DEVX-2457

When running autoconfig in interactive mode, users are now prompted to confirm or change the detected framework. This allows correcting misdetected frameworks or selecting a framework when none was detected, defaulting to "Static" in that case.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: self-explanatory UX improvement

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner February 7, 2026 22:41
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 7, 2026

🦋 Changeset detected

Latest commit: 3597daa

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 7, 2026

Claude finished @dario-piotrowicz's task —— View job


Changeset Review

  • Read changeset guidelines
  • Review changeset file
  • Check for cute animal image
  • Validate and provide feedback

All changesets look good

The changeset .changeset/friendly-icons-dance.md is well-formatted and follows all guidelines:

  • ✅ Version type is appropriate (minor for new interactive feature)
  • ✅ Clear, descriptive title and body explaining the feature and use case
  • ✅ No problematic markdown headers
  • ✅ Correctly scoped to wrangler package

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

Comment thread packages/wrangler/src/autoconfig/details.ts Outdated
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 7, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12479

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12479

miniflare

npm i https://pkg.pr.new/miniflare@12479

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12479

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12479

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12479

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12479

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12479

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12479

wrangler

npm i https://pkg.pr.new/wrangler@12479

commit: 6ba9aa2

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2457/autoconfig-edit-framework branch from 1c52873 to 6ba9aa2 Compare February 7, 2026 22:53
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2457/autoconfig-edit-framework branch from 6ba9aa2 to 3597daa Compare February 9, 2026 09:23
@@ -18,39 +18,37 @@ import type { Framework } from ".";
export type FrameworkInfo = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought for the future...
I wonder if you could put id and name as static props on the class, and then avoid needing this type? Might need to rename name to title though...

E.g.

export interface FrameworkClass {
  id: string;
  title: string;
  new (...args: any[]): any;
}

class Angular extends Framework {
  static id = "angular";
  static title = "Angular"
}

const allKnownFrameworks: FrameworkClass[] = [
  Analog,
  Angular,
  ...
] as const;
expect(allKnownFrameworks[0].id).toEqual("angular");
expect(allKnownFrameworks[0].title).toEqual("Angular");

This might be too awkward to implement but just thought it might be interesting to consider.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you could put id and name as static props on the class, and then avoid needing this type? Might need to rename name to title though...

Yes, I definitely thought of this as well in the past! 👍

The tricky bit is that we currently get this info from the netlify package, so although we could have static fields of our own, we'd be unnecessarily duplicate these values... I think it's work reconsidering this at some point 🙂

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 9, 2026
@dario-piotrowicz dario-piotrowicz merged commit fd902aa into main Feb 9, 2026
38 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/DEVX-2457/autoconfig-edit-framework branch February 9, 2026 14:52
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants